From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Sat, 3 Oct 2009 04:00:06 +0400 From: Alexey Dobriyan To: Stephen Hemminger Cc: "David S. Miller" , Karsten Keil , Andreas Eversberg , Matthias Urlichs , Hannes Eder , Michal Ostrowski , Cyrill Gorcunov , Rusty Russell , James Chapman , Johannes Berg , Marcel Holtmann , "Gustavo F. Padovan" , Andrew Morton , Harvey Harrison , Arnaldo Carvalho de Melo , Mark Smith , Eric Dumazet , Alan Cox , David Woodhouse , Chas Williams , Joerg Reuter , Ralf Baechle , Bernard Pidoux F6BVP , James Morris , Dave Young , Jan Engelhardt , Oliver Hartkopp , Ingo Molnar , Johan Hedberg , Urs Thuermann , Christine Caulfield , Dmitry Eremin-Solenikov , Sergey Lapin , Alexey Kuznetsov , "Pekka Savola (ipv6)" , Hideaki YOSHIFUJI , Patrick McHardy , Herbert Xu , "Denis V. Lunev" , Vlad Yasevich , Samuel Ortiz , Ursula Braun , linux390@de.ibm.com, Hendrik Brueckner , Qinghuang Feng , Jiri Pirko , Pablo Neira Ayuso , remi.denis-courmont@nokia.com, Andy Grover , Huang Weiyi , David Howells , Dan Carpenter , Al Viro , Henner Eisen , netdev@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-hams@vger.kernel.org, linux-decnet-user@lists.sourceforge.net, linux-zigbee-devel@lists.sourceforge.net, linux-s390@vger.kernel.org, rds-devel@oss.oracle.com, linux-afs@lists.infradead.org, linux-x25@vger.kernel.org Subject: Re: [PATCH 1/1] net: mark net_proto_ops as const Message-ID: <20091003000006.GA2020@x200> References: <20091002232520.925496630@vyatta.com> <20091002232721.385245919@vyatta.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20091002232721.385245919@vyatta.com> List-ID: On Fri, Oct 02, 2009 at 04:25:21PM -0700, Stephen Hemminger wrote: > --- a/net/can/af_can.c > +++ b/net/can/af_can.c > @@ -842,7 +842,7 @@ static struct packet_type can_packet __r > .func = can_rcv, > }; > > -static struct net_proto_family can_family_ops __read_mostly = { > +static const struct net_proto_family can_family_ops __read_mostly = { ^^^^^^^^^^^^^ > .family = PF_CAN, > .create = can_create, > .owner = THIS_MODULE, ACK, except this chunk: const already means read-only. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexey Dobriyan Subject: Re: [PATCH 1/1] net: mark net_proto_ops as const Date: Sat, 3 Oct 2009 04:00:06 +0400 Message-ID: <20091003000006.GA2020@x200> References: <20091002232520.925496630@vyatta.com> <20091002232721.385245919@vyatta.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20091002232721.385245919-ZtmgI6mnKB3QT0dZR+AlfA@public.gmane.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-zigbee-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Stephen Hemminger Cc: Bernard Pidoux F6BVP , Dan Carpenter , Andy Grover , Henner Eisen , Christine Caulfield , Ursula Braun , James Morris , David Howells , Hendrik Brueckner , Matthias Urlichs , "Denis V. Lunev" , linux-afs-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Alan Cox , Harvey Harrison , Chas Williams , linux-s390-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Mark Smith , "Pekka Savola (ipv6)" , Eric Dumazet , Huang Weiyi , James Chapman , Johan Hedberg , Arnaldo On Fri, Oct 02, 2009 at 04:25:21PM -0700, Stephen Hemminger wrote: > --- a/net/can/af_can.c > +++ b/net/can/af_can.c > @@ -842,7 +842,7 @@ static struct packet_type can_packet __r > .func = can_rcv, > }; > > -static struct net_proto_family can_family_ops __read_mostly = { > +static const struct net_proto_family can_family_ops __read_mostly = { ^^^^^^^^^^^^^ > .family = PF_CAN, > .create = can_create, > .owner = THIS_MODULE, ACK, except this chunk: const already means read-only. ------------------------------------------------------------------------------ Come build with us! The BlackBerry® Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9-12, 2009. Register now! http://p.sf.net/sfu/devconf From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexey Dobriyan Subject: Re: [PATCH 1/1] net: mark net_proto_ops as const Date: Sat, 3 Oct 2009 04:00:06 +0400 Message-ID: <20091003000006.GA2020@x200> References: <20091002232520.925496630@vyatta.com> <20091002232721.385245919@vyatta.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Bernard Pidoux F6BVP , Dan Carpenter , Andy Grover , Henner Eisen , Christine Caulfield , Ursula Braun , James Morris , David Howells , Hendrik Brueckner , Matthias Urlichs , "Denis V. Lunev" , linux-afs-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Alan Cox , Harvey Harrison , Chas Williams , linux-s390-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Mark Smith , "Pekka Savola \(ipv6\)" , Eric Dumazet , Huang Weiyi , James Chapman , Johan Hedberg , Arnaldo Carvalho de M To: Stephen Hemminger Return-path: Content-Disposition: inline In-Reply-To: <20091002232721.385245919-ZtmgI6mnKB3QT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-zigbee-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: netdev.vger.kernel.org On Fri, Oct 02, 2009 at 04:25:21PM -0700, Stephen Hemminger wrote: > --- a/net/can/af_can.c > +++ b/net/can/af_can.c > @@ -842,7 +842,7 @@ static struct packet_type can_packet __r > .func = can_rcv, > }; > > -static struct net_proto_family can_family_ops __read_mostly = { > +static const struct net_proto_family can_family_ops __read_mostly = { ^^^^^^^^^^^^^ > .family = PF_CAN, > .create = can_create, > .owner = THIS_MODULE, ACK, except this chunk: const already means read-only. ------------------------------------------------------------------------------ Come build with us! The BlackBerry® Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9-12, 2009. Register now! http://p.sf.net/sfu/devconf