From: Gleb Natapov <gleb@redhat.com>
To: Kevin O'Connor <kevin@koconnor.net>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH v2][SEABIOS] Move qemu config port access functions into separate file.
Date: Sun, 4 Oct 2009 15:06:49 +0200 [thread overview]
Message-ID: <20091004130649.GC9832@redhat.com> (raw)
In-Reply-To: <20091004130109.GA2472@morn.localdomain>
On Sun, Oct 04, 2009 at 09:01:09AM -0400, Kevin O'Connor wrote:
> On Sun, Oct 04, 2009 at 11:09:07AM +0200, Gleb Natapov wrote:
> >
> > Move qemu config code from smbios.c to its own files. Add support for
> > -boot menu=on|off qemu option.
>
> Thanks Gleb.
>
> Please rename the "pv" files - at a minimum to "paravirt", although I
> think "qemucfg" or "emucfg" is more appropriate.
>
I want to put things like kvm_para_available() there too. qemucfg naming
suggest that this is only qemu fw_cfg driver, but I want it to be more.
I'll rename it to paravirt.[ch]
> The other thing is new ".c" files need a one line description and a
> copyright at the top. If you don't care about the copyright then just
> reuse Fabrice's from smbios.c.
>
> If you wish, I can make these changes.
>
I'll resend.
--
Gleb.
prev parent reply other threads:[~2009-10-04 13:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-04 9:09 [Qemu-devel] [PATCH v2][SEABIOS] Move qemu config port access functions into separate file Gleb Natapov
2009-10-04 13:01 ` [Qemu-devel] " Kevin O'Connor
2009-10-04 13:06 ` Gleb Natapov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091004130649.GC9832@redhat.com \
--to=gleb@redhat.com \
--cc=kevin@koconnor.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.