From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Shawn O. Pearce" <spearce@spearce.org>, git@vger.kernel.org
Subject: Re: Interim maintainer tree
Date: Sun, 4 Oct 2009 09:29:36 -0400 [thread overview]
Message-ID: <20091004132936.GA13804@sigill.intra.peff.net> (raw)
In-Reply-To: <7viqevpjr3.fsf@alter.siamese.dyndns.org>
On Sun, Oct 04, 2009 at 02:54:08AM -0700, Junio C Hamano wrote:
> > - silence gcc warning:
> > http://article.gmane.org/gmane.comp.version-control.git/129485
> > The warning is overly cautious, I think, but it is a dubious enough
> > construct that it is probably worth fixing.
>
> I cannot reach gmane now, but if this is about -Wextra, I'd rather not
> touch it before the release. "comparison between signed and unsigned"
> tends to be excessive and IMNSHO it is crazy to use -Wextra and -Werror
> together.
Actually, I mislabeled this. It is about a glibc run-time complaint not
a gcc warning, which is more worrisome. It is triggered by an argv list
where we pass (argv - 1) to something expecting only to index it
starting from '1'. I'm not sure yet if it is glibc being picky or if we
violate that assumption somewhere. I'll post a followup in the thread.
-Peff
next prev parent reply other threads:[~2009-10-04 13:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-25 16:05 Interim maintainer tree Shawn O. Pearce
2009-09-27 8:54 ` Jeff King
2009-10-04 6:06 ` Junio C Hamano
2009-10-04 6:41 ` Jeff King
2009-10-04 9:54 ` Junio C Hamano
2009-10-04 13:29 ` Jeff King [this message]
2009-10-05 14:56 ` Shawn O. Pearce
2009-10-05 15:05 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091004132936.GA13804@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.