From: Andrew Morton <akpm@linux-foundation.org>
To: Philipp Reisner <philipp.reisner@linbit.com>
Cc: Evgeniy Polyakov <zbr@ioremap.net>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Lars Ellenberg <lars.ellenberg@linbit.com>
Subject: Re: [PATCH] connector: Removed the destruct_data callback since it is always kfree_skb()
Date: Sun, 4 Oct 2009 14:57:55 -0700 [thread overview]
Message-ID: <20091004145755.90312e7e.akpm@linux-foundation.org> (raw)
In-Reply-To: <1254235692-1631-5-git-send-email-philipp.reisner@linbit.com>
On Tue, 29 Sep 2009 16:48:11 +0200 Philipp Reisner <philipp.reisner@linbit.com> wrote:
> Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
> Acked-by: Lars Ellenberg <lars.ellenberg@linbit.com>
Please don't send unchangelogged patches.
> index 163c3e3..210338e 100644
> --- a/drivers/connector/cn_queue.c
> +++ b/drivers/connector/cn_queue.c
> @@ -83,8 +83,8 @@ void cn_queue_wrapper(struct work_struct *work)
>
> d->callback(msg, nsp);
>
> - d->destruct_data(d->ddata);
> - d->ddata = NULL;
> + kfree_skb(d->skb);
> + d->skb = NULL;
>
> kfree(d->free);
> }
So.. why is this a good thing to do? The patchset removes the option
of ever putting anything other than an skb* into the callback data, it
does this without any dicussion or justification and it does it under
the guise of "allowing permission checking in the receiver callbacks".
next prev parent reply other threads:[~2009-10-04 21:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-29 14:48 [PATCH] connector: Allow permission checking in the receiver callbacks Philipp Reisner
2009-09-29 14:48 ` [PATCH] connector: Keep the skb in cn_callback_data Philipp Reisner
2009-09-29 14:48 ` [PATCH] connector: Provide the sender's credentials to the callback Philipp Reisner
2009-09-29 14:48 ` [PATCH] connector/dm: Fixed a compilation warning Philipp Reisner
2009-09-29 14:48 ` [PATCH] connector: Removed the destruct_data callback since it is always kfree_skb() Philipp Reisner
2009-10-04 21:57 ` Andrew Morton [this message]
2009-10-04 21:53 ` [PATCH] connector: Provide the sender's credentials to the callback Andrew Morton
2009-10-04 21:50 ` [PATCH] connector: Keep the skb in cn_callback_data Andrew Morton
2009-09-30 11:20 ` [PATCH] connector: Allow permission checking in the receiver callbacks Evgeniy Polyakov
2009-09-30 13:20 ` Lars Ellenberg
2009-09-30 19:29 ` Evgeniy Polyakov
2009-10-01 8:01 ` Lars Ellenberg
2009-10-04 10:23 ` Evgeniy Polyakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091004145755.90312e7e.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=lars.ellenberg@linbit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=philipp.reisner@linbit.com \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.