From: Petter Urkedal <urkedal@nbi.dk>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeff King <peff@peff.net>,
git@vger.kernel.org, Stephen Boyd <bebarino@gmail.com>
Subject: Re: [PATCH] Reserve a slot for argv[0] in default_arg.
Date: Mon, 5 Oct 2009 08:36:49 +0200 [thread overview]
Message-ID: <20091005063649.GA25040@eideticdew.org> (raw)
In-Reply-To: <7v4oqen6my.fsf@alter.siamese.dyndns.org>
On 2009-10-04, Junio C Hamano wrote:
> It is a command specific aliasing mechanism; not even I use the feature
> these days, since "alias.*" is much easier to use. But there is no strong
> need to remove it either; it is not too much hassle to keep it for people
> who do use it. Perhaps deprecate it and remove it in the long run?
I didn't know about alias.*. Excellent. I'll be using that.
> > Correct. Junio sent a patch to fix this problem in June[1]. I guess he
> > must have dropped his own patch, or he wasn't satisfied with how parse
> > options clobbers things.
> >
> > [1] http://article.gmane.org/gmane.comp.version-control.git/121142
>
> I had it kept still in my Inbox; thanks for noticing. Petter's patch does
> essentially the same thing, but the old patch had a better log message
> that described where in the history the fix should apply, so I'd probably
> use that with your test squashed in.
The code is slightly nicer to, I think, but you can probably drop "+ 20"
in the grow-case now.
next prev parent reply other threads:[~2009-10-05 6:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-03 13:29 [PATCH] Reserve a slot for argv[0] in default_arg Petter Urkedal
2009-10-04 13:33 ` Jeff King
2009-10-04 14:13 ` Petter Urkedal
2009-10-04 18:27 ` Jeff King
2009-10-04 20:02 ` Stephen Boyd
2009-10-04 22:20 ` Junio C Hamano
2009-10-05 6:36 ` Petter Urkedal [this message]
2009-10-05 18:45 ` Jeff King
2009-10-05 6:44 ` Petter Urkedal
2009-10-04 14:51 ` Petter Urkedal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091005063649.GA25040@eideticdew.org \
--to=urkedal@nbi.dk \
--cc=bebarino@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.