From: Theodore Tso <tytso@mit.edu>
To: Eric Sandeen <sandeen@redhat.com>
Cc: ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH 2/2] pu branch: make fs->group_desc opaque
Date: Mon, 5 Oct 2009 10:57:23 -0400 [thread overview]
Message-ID: <20091005145723.GG13512@mit.edu> (raw)
In-Reply-To: <4ABC2C83.8080504@redhat.com>
On Thu, Sep 24, 2009 at 09:35:47PM -0500, Eric Sandeen wrote:
> To prevent direct array indexing of fs->group_desc[i] (because
> the group_desc may be a different size for different filesystems)
> make it an opaque pointer that may only be accessed through the
> accessor functions in blknum.c. The type itself is still available
> in a public header; if we have a group_desc that we know is one type
> or another, it's ok to access its fields directly. This change only
> prevents us from indexing off fs->group_desc[i] directly.
>
> Change the accessors in blknum.c to use ext4fs_group_desc(), a version
> of ext2fs_group_desc() which returns a ext3_group_desc pointer.
>
> This simplifies and collapses a fair bit of code in blknum.c
>
> Tested with "make check" but no 64-bit testing yet.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Thanks, I've added it to the pu branch in my sources.
- Ted
prev parent reply other threads:[~2009-10-05 14:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-25 2:35 [PATCH 2/2] pu branch: make fs->group_desc opaque Eric Sandeen
2009-10-05 14:57 ` Theodore Tso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091005145723.GG13512@mit.edu \
--to=tytso@mit.edu \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.