From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sukadev Bhattiprolu Subject: Re: [PATCH 3/4] signals: cosmetic, collect_signal: use SI_USER Date: Mon, 5 Oct 2009 11:03:54 -0700 Message-ID: <20091005180354.GC30442@us.ibm.com> References: <4AC608BE.9020805@fr.ibm.com> <20091003171029.GA30442@us.ibm.com> <20091004021844.GA21006@redhat.com> <20091004022021.GD21006@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20091004022021.GD21006-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Oleg Nesterov Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Linux Containers , Andrew Morton , Daniel Lezcano , roland-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org List-Id: containers.vger.kernel.org Oleg Nesterov [oleg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org] wrote: | Trivial, s/0/SI_USER/ in collect_signal() for grep. | | This is a bit confusing, we don't know the source of this signal. | But we don't care, and "info->si_code = 0" is imho worse. | | Signed-off-by: Oleg Nesterov Reviewed-by: Sukadev Bhattiprolu | --- | | kernel/signal.c | 2 +- | 1 file changed, 1 insertion(+), 1 deletion(-) | | --- TTT_32/kernel/signal.c~3_COLLECT_SIGNAL 2009-10-04 03:09:44.000000000 +0200 | +++ TTT_32/kernel/signal.c 2009-10-04 03:48:48.000000000 +0200 | @@ -400,7 +400,7 @@ still_pending: | */ | info->si_signo = sig; | info->si_errno = 0; | - info->si_code = 0; | + info->si_code = SI_USER; | info->si_pid = 0; | info->si_uid = 0; | } From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754393AbZJESEQ (ORCPT ); Mon, 5 Oct 2009 14:04:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754341AbZJESEP (ORCPT ); Mon, 5 Oct 2009 14:04:15 -0400 Received: from e2.ny.us.ibm.com ([32.97.182.142]:59474 "EHLO e2.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754295AbZJESEP (ORCPT ); Mon, 5 Oct 2009 14:04:15 -0400 Date: Mon, 5 Oct 2009 11:03:54 -0700 From: Sukadev Bhattiprolu To: Oleg Nesterov Cc: Andrew Morton , Daniel Lezcano , Sukadev Bhattiprolu , Linux Containers , roland@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] signals: cosmetic, collect_signal: use SI_USER Message-ID: <20091005180354.GC30442@us.ibm.com> References: <4AC608BE.9020805@fr.ibm.com> <20091003171029.GA30442@us.ibm.com> <20091004021844.GA21006@redhat.com> <20091004022021.GD21006@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091004022021.GD21006@redhat.com> X-Operating-System: Linux 2.0.32 on an i486 User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Oleg Nesterov [oleg@redhat.com] wrote: | Trivial, s/0/SI_USER/ in collect_signal() for grep. | | This is a bit confusing, we don't know the source of this signal. | But we don't care, and "info->si_code = 0" is imho worse. | | Signed-off-by: Oleg Nesterov Reviewed-by: Sukadev Bhattiprolu | --- | | kernel/signal.c | 2 +- | 1 file changed, 1 insertion(+), 1 deletion(-) | | --- TTT_32/kernel/signal.c~3_COLLECT_SIGNAL 2009-10-04 03:09:44.000000000 +0200 | +++ TTT_32/kernel/signal.c 2009-10-04 03:48:48.000000000 +0200 | @@ -400,7 +400,7 @@ still_pending: | */ | info->si_signo = sig; | info->si_errno = 0; | - info->si_code = 0; | + info->si_code = SI_USER; | info->si_pid = 0; | info->si_uid = 0; | }