All of lore.kernel.org
 help / color / mirror / Atom feed
From: Frederic Weisbecker <fweisbec@gmail.com>
To: Masami Hiramatsu <mhiramat@redhat.com>
Cc: Steven Rostedt <rostedt@goodmis.org>, Ingo Molnar <mingo@elte.hu>,
	lkml <linux-kernel@vger.kernel.org>,
	systemtap <systemtap@sources.redhat.com>,
	DLE <dle-develop@lists.sourceforge.net>,
	Thomas Gleixner <tglx@linutronix.de>,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	Mike Galbraith <efault@gmx.de>, Paul Mackerras <paulus@samba.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Christoph Hellwig <hch@infradead.org>,
	Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
	Jim Keniston <jkenisto@us.ibm.com>,
	"Frank Ch. Eigler" <fche@redhat.com>
Subject: Re: [PATCH tracing/kprobes v2 1/5] tracing/kprobes: Rename special variables syntax
Date: Mon, 5 Oct 2009 21:26:11 +0200	[thread overview]
Message-ID: <20091005192609.GB6071@nowhere> (raw)
In-Reply-To: <4ACA25D5.10703@redhat.com>

On Mon, Oct 05, 2009 at 12:59:01PM -0400, Masami Hiramatsu wrote:
> As far as I can see in arch/*/include/asm/ptrace.h, all registers start with
> alphabets :-). So, I'd like to suggest renaming sp-vars to '_sp-vars'.
>
> Then, we will have;
> - $local-vars


There is a risk of bash collision.


> - @global-symbol


We could use global-symbol as is. Shadowing between global
and local vars could be dealt with scope resolution:

function:var
file:var
file:line:var

And throw errors while submitting a shadowed var name, crying until
the user defines the scope, only if needed of course (if there are
no shadowing detected, we can submit a naked variable name).


> - regs


That can conflict with variable names


> - _sp-vars


That too.


> - +|-Offs(ARG)

You mean for arg numbers?
So we would have +1 for argument 1?

arg(1) looks more easy to remember and to understand, no?

Thanks.


  reply	other threads:[~2009-10-05 19:26 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-02 21:48 [PATCH tracing/kprobes v2 0/5] tracing/kprobes, perf: perf probe support take 2 Masami Hiramatsu
2009-10-02 21:48 ` [PATCH tracing/kprobes v2 1/5] tracing/kprobes: Rename special variables syntax Masami Hiramatsu
2009-10-03  1:54   ` Frederic Weisbecker
2009-10-04  5:21     ` Masami Hiramatsu
2009-10-05 16:59       ` Masami Hiramatsu
2009-10-05 19:26         ` Frederic Weisbecker [this message]
2009-10-05 21:05           ` Masami Hiramatsu
2009-10-05 21:11             ` Frederic Weisbecker
2009-10-06  0:12           ` Steven Rostedt
2009-10-06 14:23             ` Masami Hiramatsu
2009-10-06 22:47               ` Frederic Weisbecker
2009-10-07  1:13                 ` Masami Hiramatsu
2009-10-07 16:28                   ` Frederic Weisbecker
2009-10-07  0:15               ` Steven Rostedt
2009-10-07  2:57                 ` Masami Hiramatsu
2009-10-06 22:42             ` Frederic Weisbecker
2009-10-05 19:18       ` Frederic Weisbecker
2009-10-05 19:38         ` Frederic Weisbecker
2009-10-05 20:18         ` Masami Hiramatsu
2009-10-05 20:58           ` Frederic Weisbecker
2009-10-05 21:11             ` Masami Hiramatsu
2009-10-05 21:21               ` Frederic Weisbecker
2009-10-05 21:34                 ` Masami Hiramatsu
2009-10-05 21:55                   ` Frederic Weisbecker
2009-10-05 22:09                     ` Frederic Weisbecker
2009-10-05 22:38                     ` Masami Hiramatsu
2009-10-05 22:42                       ` Masami Hiramatsu
2009-10-02 21:48 ` [PATCH tracing/kprobes v2 2/5] tracing/kprobes: Avoid field name confliction Masami Hiramatsu
2009-10-06  0:16   ` Steven Rostedt
2009-10-06  1:07     ` Masami Hiramatsu
2009-10-02 21:48 ` [PATCH tracing/kprobes v2 3/5] tracing/kprobes: Rename fixed field name Masami Hiramatsu
2009-10-02 21:49 ` [PATCH tracing/kprobes v2 4/5] perf: Add perf probe subcommand for kprobe-event setup helper Masami Hiramatsu
2009-10-06  0:29   ` Steven Rostedt
2009-10-06  0:57     ` Masami Hiramatsu
2009-10-06  1:20       ` Steven Rostedt
2009-10-06  1:43       ` Arnaldo Carvalho de Melo
2009-10-06  9:03       ` Peter Zijlstra
2009-10-07  3:22         ` Masami Hiramatsu
2009-10-02 21:49 ` [PATCH tracing/kprobes v2 5/5] perf: kprobe command supports without libdwarf Masami Hiramatsu
2009-10-03  1:25 ` [PATCH tracing/kprobes v2 0/5] tracing/kprobes, perf: perf probe support take 2 Frederic Weisbecker
2009-10-05 14:54 ` Frank Ch. Eigler
2009-10-05 15:10   ` Masami Hiramatsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091005192609.GB6071@nowhere \
    --to=fweisbec@gmail.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@redhat.com \
    --cc=ananth@in.ibm.com \
    --cc=dle-develop@lists.sourceforge.net \
    --cc=efault@gmx.de \
    --cc=fche@redhat.com \
    --cc=hch@infradead.org \
    --cc=jkenisto@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhiramat@redhat.com \
    --cc=mingo@elte.hu \
    --cc=paulus@samba.org \
    --cc=rostedt@goodmis.org \
    --cc=systemtap@sources.redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.