From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oleg Nesterov Subject: Re: [PATCH 2/4] signals: send_signal: use si_fromuser() to detect from_ancestor_ns Date: Mon, 5 Oct 2009 21:55:44 +0200 Message-ID: <20091005195544.GA5377@redhat.com> References: <4AC608BE.9020805@fr.ibm.com> <20091003171029.GA30442@us.ibm.com> <20091004021844.GA21006@redhat.com> <20091004021954.GC21006@redhat.com> <20091005181255.GE30442@us.ibm.com> <20091005182536.GA943@redhat.com> <20091005193738.GF30442@us.ibm.com> <20091005194415.GA4560@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20091005194415.GA4560-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Sukadev Bhattiprolu Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Linux Containers , Andrew Morton , Daniel Lezcano , roland-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org List-Id: containers.vger.kernel.org On 10/05, Oleg Nesterov wrote: > > On 10/05, Sukadev Bhattiprolu wrote: > > > > Oleg Nesterov [oleg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org] wrote: > > > | So, imho this patch also fixes this case by accident, > > > > This part I am not sure. But as mentioned above, from_ancestor_ns is 0 > > and the SIGKILL will not queued right ? > > Yes, you are right, see above. > > I meant, it fixes the from-user logic, not from_ancestor_ns logic. Hmm. When I re-read that email, I do not understand any longer what I reallly meant when I said "this patch also fixes this case" :) Anyway, you are right, thanks for correcting me.OH Oleg. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754705AbZJEUAj (ORCPT ); Mon, 5 Oct 2009 16:00:39 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754620AbZJEUAj (ORCPT ); Mon, 5 Oct 2009 16:00:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33455 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753294AbZJEUAi (ORCPT ); Mon, 5 Oct 2009 16:00:38 -0400 Date: Mon, 5 Oct 2009 21:55:44 +0200 From: Oleg Nesterov To: Sukadev Bhattiprolu Cc: Andrew Morton , Daniel Lezcano , Sukadev Bhattiprolu , Linux Containers , roland@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] signals: send_signal: use si_fromuser() to detect from_ancestor_ns Message-ID: <20091005195544.GA5377@redhat.com> References: <4AC608BE.9020805@fr.ibm.com> <20091003171029.GA30442@us.ibm.com> <20091004021844.GA21006@redhat.com> <20091004021954.GC21006@redhat.com> <20091005181255.GE30442@us.ibm.com> <20091005182536.GA943@redhat.com> <20091005193738.GF30442@us.ibm.com> <20091005194415.GA4560@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091005194415.GA4560@redhat.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/05, Oleg Nesterov wrote: > > On 10/05, Sukadev Bhattiprolu wrote: > > > > Oleg Nesterov [oleg@redhat.com] wrote: > > > | So, imho this patch also fixes this case by accident, > > > > This part I am not sure. But as mentioned above, from_ancestor_ns is 0 > > and the SIGKILL will not queued right ? > > Yes, you are right, see above. > > I meant, it fixes the from-user logic, not from_ancestor_ns logic. Hmm. When I re-read that email, I do not understand any longer what I reallly meant when I said "this patch also fixes this case" :) Anyway, you are right, thanks for correcting me.OH Oleg.