From: David Miller <davem@davemloft.net>
To: bzolnier@gmail.com
Cc: torvalds@linux-foundation.org, joao.ramos@inov.pt,
david@fries.net, d.stussy@yahoo.com, linux-ide@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] Revert "Revert "ide: try to use PIO Mode 0 during probe if possible""
Date: Tue, 06 Oct 2009 15:57:05 -0700 (PDT) [thread overview]
Message-ID: <20091006.155705.26059456.davem@davemloft.net> (raw)
In-Reply-To: <200910070052.37964.bzolnier@gmail.com>
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Date: Wed, 7 Oct 2009 00:52:37 +0200
> On Wednesday 07 October 2009 00:41:20 David Miller wrote:
>> From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
>> Date: Wed, 7 Oct 2009 00:27:45 +0200
>>
>> > The root cause of reported system hangs was (now fixed) sis5513 bug
>> > and not "ide: try to use PIO Mode 0 during probe if possible" change
>> > (commit 6029336426a2b43e4bc6f4a84be8789a047d139e) so the revert was
>> > incorrect (it simply replaced one regression with the other one).
>>
>> What is this older "regression" fixed by the PIO-0 change?
>>
>> You're not explaining it and neither does the commit message for the
>> PIO-0 change.
>
> It does:
>
> | Subject: [PATCH] sis5513: fix PIO setup for ATAPI devices
Sorry, I wasn't clear.
I'm talking about commit 6029336426a2b43e4bc6f4a84be8789a047d139e, it
doesn't say why we want to try PIO 0 mode during probe.
What was the regression fixed by that change?
next prev parent reply other threads:[~2009-10-06 22:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-06 22:27 [PATCH 2/2] Revert "Revert "ide: try to use PIO Mode 0 during probe if possible"" Bartlomiej Zolnierkiewicz
2009-10-06 22:41 ` David Miller
2009-10-06 22:52 ` Bartlomiej Zolnierkiewicz
2009-10-06 22:57 ` David Miller [this message]
2009-10-06 23:13 ` Bartlomiej Zolnierkiewicz
2009-10-06 23:34 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091006.155705.26059456.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bzolnier@gmail.com \
--cc=d.stussy@yahoo.com \
--cc=david@fries.net \
--cc=joao.ramos@inov.pt \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.