From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sukadev Bhattiprolu Subject: Re: [PATCH 1/4] signals: SEND_SIG_NOINFO should be considered as SI_FROMUSER() Date: Mon, 5 Oct 2009 17:09:11 -0700 Message-ID: <20091006000911.GB4390@us.ibm.com> References: <4AC608BE.9020805@fr.ibm.com> <20091003171029.GA30442@us.ibm.com> <20091004021844.GA21006@redhat.com> <20091004021918.GB21006@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20091004021918.GB21006-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Oleg Nesterov Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Linux Containers , Andrew Morton , Daniel Lezcano , roland-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org List-Id: containers.vger.kernel.org Oleg Nesterov [oleg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org] wrote: | No changes in compiled code. The patch adds the new helper, si_fromuser() | and changes check_kill_permission() to use this helper. | | The real effect of this patch is that from now we "officially" consider | SEND_SIG_NOINFO signal as "from user-space" signals. This is already true | if we look at the code which uses SEND_SIG_NOINFO, except __send_signal() | has another opinion - see the next patch. | | The naming of these special SEND_SIG_XXX siginfo's is really bad imho. | >From __send_signal()'s pov they mean | | SEND_SIG_NOINFO from user | SEND_SIG_PRIV from kernel | SEND_SIG_FORCED no info | | Signed-off-by: Oleg Nesterov Renaming the special siginfo cases be done independently. Reviewed-by: Sukadev Bhattiprolu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755603AbZJFAJb (ORCPT ); Mon, 5 Oct 2009 20:09:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755438AbZJFAJb (ORCPT ); Mon, 5 Oct 2009 20:09:31 -0400 Received: from e8.ny.us.ibm.com ([32.97.182.138]:59218 "EHLO e8.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754995AbZJFAJa (ORCPT ); Mon, 5 Oct 2009 20:09:30 -0400 Date: Mon, 5 Oct 2009 17:09:11 -0700 From: Sukadev Bhattiprolu To: Oleg Nesterov Cc: Andrew Morton , Daniel Lezcano , Sukadev Bhattiprolu , Linux Containers , roland@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] signals: SEND_SIG_NOINFO should be considered as SI_FROMUSER() Message-ID: <20091006000911.GB4390@us.ibm.com> References: <4AC608BE.9020805@fr.ibm.com> <20091003171029.GA30442@us.ibm.com> <20091004021844.GA21006@redhat.com> <20091004021918.GB21006@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091004021918.GB21006@redhat.com> X-Operating-System: Linux 2.0.32 on an i486 User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Oleg Nesterov [oleg@redhat.com] wrote: | No changes in compiled code. The patch adds the new helper, si_fromuser() | and changes check_kill_permission() to use this helper. | | The real effect of this patch is that from now we "officially" consider | SEND_SIG_NOINFO signal as "from user-space" signals. This is already true | if we look at the code which uses SEND_SIG_NOINFO, except __send_signal() | has another opinion - see the next patch. | | The naming of these special SEND_SIG_XXX siginfo's is really bad imho. | >From __send_signal()'s pov they mean | | SEND_SIG_NOINFO from user | SEND_SIG_PRIV from kernel | SEND_SIG_FORCED no info | | Signed-off-by: Oleg Nesterov Renaming the special siginfo cases be done independently. Reviewed-by: Sukadev Bhattiprolu