From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sukadev Bhattiprolu Subject: Re: [PATCH 2/4] signals: send_signal: use si_fromuser() to detect from_ancestor_ns Date: Mon, 5 Oct 2009 17:16:31 -0700 Message-ID: <20091006001631.GC4390@us.ibm.com> References: <4AC608BE.9020805@fr.ibm.com> <20091003171029.GA30442@us.ibm.com> <20091004021844.GA21006@redhat.com> <20091004021954.GC21006@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20091004021954.GC21006-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Oleg Nesterov Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Linux Containers , Andrew Morton , Daniel Lezcano , roland-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org List-Id: containers.vger.kernel.org Oleg Nesterov [oleg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org] wrote: | Change send_signal() to use si_fromuser(). From now SEND_SIG_NOINFO | triggers the "from_ancestor_ns" check. | | This fixes reparent_thread()->group_send_sig_info(pdeath_signal) | behaviour, before this patch send_signal() does not detect the | cross-namespace case when the child of the dying parent belongs | to the sub-namespace. | | This patch can affect the behaviour of send_sig(), kill_pgrp() and | kill_pid() when the caller sends the signal to the sub-namespace | with "priv == 0" but surprisingly all callers seem to use them | correctly, including disassociate_ctty(on_exit). | | Except: drivers/staging/comedi/drivers/addi-data/*.c incorrectly | use send_sig(priv => 0). But his is minor and should be fixed | anyway. | | Reported-by: Daniel Lezcano | Signed-off-by: Oleg Nesterov Since, addressing the problem of container-init sending SIGKILL to itself would have to be a separate patch: Reviewed-by: Sukadev Bhattiprolu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755702AbZJFAQv (ORCPT ); Mon, 5 Oct 2009 20:16:51 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755510AbZJFAQu (ORCPT ); Mon, 5 Oct 2009 20:16:50 -0400 Received: from e7.ny.us.ibm.com ([32.97.182.137]:35187 "EHLO e7.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755182AbZJFAQt (ORCPT ); Mon, 5 Oct 2009 20:16:49 -0400 Date: Mon, 5 Oct 2009 17:16:31 -0700 From: Sukadev Bhattiprolu To: Oleg Nesterov Cc: Andrew Morton , Daniel Lezcano , Sukadev Bhattiprolu , Linux Containers , roland@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] signals: send_signal: use si_fromuser() to detect from_ancestor_ns Message-ID: <20091006001631.GC4390@us.ibm.com> References: <4AC608BE.9020805@fr.ibm.com> <20091003171029.GA30442@us.ibm.com> <20091004021844.GA21006@redhat.com> <20091004021954.GC21006@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091004021954.GC21006@redhat.com> X-Operating-System: Linux 2.0.32 on an i486 User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Oleg Nesterov [oleg@redhat.com] wrote: | Change send_signal() to use si_fromuser(). From now SEND_SIG_NOINFO | triggers the "from_ancestor_ns" check. | | This fixes reparent_thread()->group_send_sig_info(pdeath_signal) | behaviour, before this patch send_signal() does not detect the | cross-namespace case when the child of the dying parent belongs | to the sub-namespace. | | This patch can affect the behaviour of send_sig(), kill_pgrp() and | kill_pid() when the caller sends the signal to the sub-namespace | with "priv == 0" but surprisingly all callers seem to use them | correctly, including disassociate_ctty(on_exit). | | Except: drivers/staging/comedi/drivers/addi-data/*.c incorrectly | use send_sig(priv => 0). But his is minor and should be fixed | anyway. | | Reported-by: Daniel Lezcano | Signed-off-by: Oleg Nesterov Since, addressing the problem of container-init sending SIGKILL to itself would have to be a separate patch: Reviewed-by: Sukadev Bhattiprolu