Re: [PATCH 11/11] hugetlb: offload per node attribute registrations

[Andi Kleen <andi@firstfloor.org>]

On Mon, Oct 05, 2009 at 11:19:24PM -0400, Lee Schermerhorn wrote:
> [PATCH 11/11] hugetlb:  offload [un]registration of sysfs attr to worker thread
> 
> Against:  2.6.31-mmotm-090925-1435
> 
> New in V6
> 
> V7:  + remove redundant check for memory{ful|less} node from 
>        node_hugetlb_work().  Rely on [added] return from
>        hugetlb_register_node() to differentiate between transitions
>        to/from memoryless state.
> 
> This patch offloads the registration and unregistration of per node
> hstate sysfs attributes to a worker thread rather than attempt the
> allocation/attachment or detachment/freeing of the attributes in 
> the context of the memory hotplug handler.

Why this change? The hotplug handler should be allowed to sleep, shouldn't it?

> N.B.,  Only tested build, boot, libhugetlbfs regression.
>        i.e., no memory hotplug testing.

Yes, you have to because I know for a fact it's broken (outside your code) :)

-Andi

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>