From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/4] ppc4xx: Cleanup some HW register names
Date: Wed, 7 Oct 2009 09:34:41 +0200 [thread overview]
Message-ID: <200910070934.41363.sr@denx.de> (raw)
In-Reply-To: <200910041739.04371.niklaus.giger@member.fsf.org>
Hi Niklaus,
On Sunday 04 October 2009 17:39:04 Niklaus Giger wrote:
> > > +++ b/include/ppc405.h
> > > @@ -578,7 +578,7 @@
> > > #define IICEXTSTS 0x09
> > > #define IICLSADR 0x0A
> > > #define IICHSADR 0x0B
> > > -#define IICCLKDIV 0x0C
> > > +#define IIC0_CLKDIV 0x0C
> > > #define IICINTRMSK 0x0D
> > > #define IICXFRCNT 0x0E
> > > #define IICXTCNTLSS 0x0F
> >
> > Why did you "only" change one of there I2C defines? Not enough time to
> > change them all? Any chance that you could change the other defines as
> > well? Or remove them if they are not used at all.
>
> Yes. No enough time and they would need cleaning up even more files.
> Please let the patch without requiring to change these definitions too. I
> will try to devote some time to them later on.
OK, I'll add your v2 patches now, since it's definitely an improvement.
Looking forward to further updates... ;)
Thanks.
Cheers,
Stefan
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de
next prev parent reply other threads:[~2009-10-07 7:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-02 18:12 [U-Boot] [PATCH 0/4] ppc4xx: Overhaul for cmd reginfo Niklaus Giger
2009-10-02 18:12 ` Niklaus Giger
2009-10-02 18:12 ` [U-Boot] [PATCH 1/4] ppc4xx: Cleanup some HW register names Niklaus Giger
2009-10-02 18:12 ` [U-Boot] [PATCH 2/4] ppc4xx: Apply new " Niklaus Giger
2009-10-02 18:12 ` [U-Boot] [PATCH 3/4] ppc4xx: Rework cmd reginfo Niklaus Giger
2009-10-02 18:12 ` [U-Boot] [PATCH 4/4] ppc4xx: respect 80-chars per line in ppc*.h files Niklaus Giger
2009-10-04 11:51 ` [U-Boot] [PATCH 3/4] ppc4xx: Rework cmd reginfo Stefan Roese
2009-10-04 11:36 ` [U-Boot] [PATCH 1/4] ppc4xx: Cleanup some HW register names Stefan Roese
2009-10-04 15:39 ` Niklaus Giger
2009-10-07 7:34 ` Stefan Roese [this message]
2009-10-04 11:31 ` [U-Boot] [PATCH 0/4] ppc4xx: Overhaul for cmd reginfo Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200910070934.41363.sr@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.