All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Christoph Hellwig <hch@infradead.org>,
	util-linux-ng@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH] xfsprogs: allow using libblkid instead of libdisk
Date: Wed, 7 Oct 2009 16:14:51 -0400	[thread overview]
Message-ID: <20091007201451.GA30192@infradead.org> (raw)
In-Reply-To: <4ACCE37F.4070006@sandeen.net>

On Wed, Oct 07, 2009 at 01:52:47PM -0500, Eric Sandeen wrote:
> Christoph Hellwig wrote:
>> Add a new --enable-blkid switch to use libblkid from util-linux to detect
>> the device geometry and check for existing partitions or filesystem on a
>> device.  Note that this requires the latest blkid from util-linux-ng git
>> for the topology calls, odler ones won't work.  If I had a little more
>> autoconf fu we might be able to detect a too early one, but right now it
>> just fails if it's too old and --enable-blkid is specified.
>
> Here's some autoconf fu to check for blkid topo support; this changes it to
> default to using blkid, optionally disable-able, and disables it automatically
> if the topo stuff isn't found (I think ;)

Thanks, I've folded it into my patch.

Btw, something I forgot to ask with the original patch:  Does anyone
have a use for the fstype binary that doesn't actually get installed?
It would be a lot cleaner to just nuke it instead of building it
conditionally.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

      reply	other threads:[~2009-10-07 20:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-06 18:52 [PATCH] xfsprogs: allow using libblkid instead of libdisk Christoph Hellwig
2009-10-07 18:52 ` Eric Sandeen
2009-10-07 20:14   ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091007201451.GA30192@infradead.org \
    --to=hch@infradead.org \
    --cc=sandeen@sandeen.net \
    --cc=util-linux-ng@vger.kernel.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.