From mboxrd@z Thu Jan  1 00:00:00 1970
From: Simon Horman <horms@verge.net.au>
Subject: Re: Possible bug with pass-through hot-plug?
Date: Thu, 8 Oct 2009 09:52:11 +1100
Message-ID: <20091007225211.GD2055@verge.net.au>
References: <8686c3cd0910070200r7f3c59d9o8964ea432372a6b2@mail.gmail.com>
	<20091007093840.GB18775@verge.net.au>
	<8686c3cd0910070256p77f58aeat23aea646aaf82b86@mail.gmail.com>
	<20091007120246.GA5088@verge.net.au>
	<8686c3cd0910070828v30b1838by29c592bfb18f27c1@mail.gmail.com>
	<8686c3cd0910070841t2dd45aebx2f8a047477807e41@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <xen-devel-bounces@lists.xensource.com>
Content-Disposition: inline
In-Reply-To: <8686c3cd0910070841t2dd45aebx2f8a047477807e41@mail.gmail.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Tom Rotenberg <tom.rotenberg@gmail.com>
Cc: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

On Wed, Oct 07, 2009 at 05:41:38PM +0200, Tom Rotenberg wrote:
> Just tried it, with xen-unstable changeset: 20249, and it also doesn't work.
> 
> When i assigned the device regularly, it was assigned to the virtual
> BDF: 00:04.0, and the detachment worked fine, but when i caused it to
> be registered on the virtual BDF 00:1b.0 - the detachment didn't
> work...
> 
> The change i made to the qemu code to make the device to be assigned
> on 00:1b.0, is:
> 
> diff --git a/hw/pass-through.c b/hw/pass-through.c
> index 8d80755..2b79812 100644
> --- a/hw/pass-through.c
> +++ b/hw/pass-through.c
> @@ -974,6 +974,7 @@ int insert_to_pci_devfn(char *bdf_slt)
>          return -1;
>      }
> 
> +    devfn = PCI_DEVFN(0x1b,0);
>      return __insert_to_pci_devfn(bus, dev, func, devfn, opt);
> 
>  }
> 
> 
> Can u please check if it works on your system?

Sure, will do.