[Qemu-devel] Re: [PATCH 2/2] Load SMBIOS entries and files from qemu

[Gleb Natapov <gleb@redhat.com>]

On Wed, Oct 07, 2009 at 07:53:26PM -0400, Kevin O'Connor wrote:
> On Wed, Oct 07, 2009 at 06:16:51PM +0200, Gleb Natapov wrote:
> > Allow SMBIOS fields to be overridden and entries replaced by those
> > read from qemu.
> > 
> > This is port of commit f4a09e759469be74e2598758bfae623b555c4cae
> > from qemu pc-bios tree.
> > 
> > Signed-off-by: Gleb Natapov <gleb@redhat.com>
> 
> Two comments:
> 
> The smbios code is allocating 2K of high ram for the full table.  Now
> that tables can be pulled in from qemu, is it assured that the space
> wont overflow?
No it is not. We should check this is and stop table loading on overflow.

> 
> [...]
> > +#define load_str_field_with_default(type, field, def)                   \
> [...]
> 
> These macros are really ugly - isn't there a better way to do this?
> 
This is direct port from qemu pcbios, so there the code is exactly the
same if it makes you feel better :) Otherwise I agree with you that
smbios table could have been done easier, but existing qemu-to-bios
interface dictates this complex implementation. I don't see how can we get
rid of this macros. Without them we will have to open code the same
logic in every place they are used. 

--
			Gleb.