From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gra-lx1.iram.es (gra-lx1.iram.es [150.214.224.41]) by ozlabs.org (Postfix) with ESMTP id D7BD2B7B70 for ; Thu, 8 Oct 2009 22:14:41 +1100 (EST) Date: Thu, 8 Oct 2009 13:14:27 +0200 From: Gabriel Paubert To: =?iso-8859-1?B?Suly9G1l?= Pouiller Subject: Re: Nested function in drivers/of/of_mdio.c Message-ID: <20091008111427.GA16941@iram.es> References: <200910071715.57249.jezz@sysmic.org> <200910081045.12590.j.pouiller@sysmic.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 In-Reply-To: <200910081045.12590.j.pouiller@sysmic.fr> Cc: netdev , linuxppc-dev@lists.ozlabs.org, Andy Fleming , "David S. Miller" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, Oct 08, 2009 at 10:45:12AM +0200, Jérôme Pouiller wrote: > I did some grep on codebase. I have not found any other instances of > nested functions, but my regexps are not enough to be 100% sure. >>From Documentation/CodingStyle, written by the Head Penguin himself: "Heretic people all over the world have claimed that this inconsistency is ... well ... inconsistent, but all right-thinking people know that (a) K&R are _right_ and (b) K&R are right. Besides, functions are special anyway (you can't nest them in C)." ^^^^^^^^^^^^^^^^^^^^^^^^ I interpret it as a clear prohibition of using nested functions in the kernel. Regards, Gabriel