Re: [PATCH] voicecall: allow P or , within the dial string

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 687 bytes --]

Hi Pekka,

> "DTMF control digit separator" is used as pause according to GSM 02.07.
> According to GSM 11.11 it is stored as BCD code 1100 in the SIM card. Nokia
> modems use 'p' to represent pause. AT commands use ',' to represent pause.

Strictly speaking AT modems use 'C' to represent the pause.  Can you point me 
to any spec that actually says ',' and 'p' are used the way you describe?

> +		/* Pause can be described with P or , */
> +		if (tones[i] == 'P' || tones[i] == ',') {
> +			tones[i] = 'p';

This should really be 'C'.

We also need to modify the code above not to accept 'D' as a valid character 
since that is a wild card value.

Regards,
-Denis