Re: [PATCH 6/8] RX-51: Audio: Add usage of regulator framework to control VMMC2

[Mark Brown <broonie@opensource.wolfsonmicro.com>]

On Thu, Oct 08, 2009 at 02:58:55PM +0300, Eduardo Valentin wrote:

> +static struct regulator_consumer_supply rx51_vmmc2_supplies[] = {
> +	REGULATOR_SUPPLY("avdd_dac", "2-0018"), /* tlv320aic3x */
> +	REGULATOR_SUPPLY("vdd", "2-0060"), /* tpa6130a2*/
>  };

avdd_dac is the only supply added for the tlv320aic3x but, for example,
the tlv320aic34 has something like 8 supplies from a quick scan of the
datasheet.  It'd be better to set up all of the supplies, even if only
with a fixed voltage regulator supplying them, since when regulator
support is added to the CODEC driver it should be requesting all the
supplies it needs and therefore fail to instatiate if some are missing.