* [PATCH 0/3] qemu: reset-related fixes
@ 2009-10-08 14:52 ` Michael S. Tsirkin
0 siblings, 0 replies; 6+ messages in thread
From: Michael S. Tsirkin @ 2009-10-08 14:52 UTC (permalink / raw)
To: Avi Kivity; +Cc: Anthony Liguori, qemu-devel@nongnu.org, kvm-devel
On Wed, Oct 07, 2009 at 10:20:19AM +0200, Avi Kivity wrote:
>> Reset BARs and a couple of other registers on bus reset, as per PCI
>> spec.
>>
>
> This commit breaks Windows XP restart. After a restart Windows switches
> from 800x600 cirrus logic vga to 640x480 standard vga.
So I think this is a bios bug. Patchset fixing this applied.
So, what's the best way to propagate the fixes upstream?
Avi, Anthony, please advise.
Avi, after applying this, you need to generate a new bios binary.
Anthony, qemu keeps bios binaries in source tree.
I can't post a patch changing these, can I?
Only people with git access can change them.
BTW, can't we keep the sources around the like qemu-kvm does?
It would be best if pc-bios used git, then we would
include a submodule, as it is we can set up a git-cvs
mirror at qemu site, and then include a submodule.
Makes sense?
Michael S. Tsirkin (3):
pc-bios: enable io/memory unconditionally
qemu: make cirrus init value pci spec compliant
qemu: cleanup unused macros in cirrus
hw/cirrus_vga.c | 38 +-------------------------------------
kvm/bios/rombios32.c | 18 +++++++-----------
2 files changed, 8 insertions(+), 48 deletions(-)
--
MST
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Qemu-devel] [PATCH 0/3] qemu: reset-related fixes
@ 2009-10-08 14:52 ` Michael S. Tsirkin
0 siblings, 0 replies; 6+ messages in thread
From: Michael S. Tsirkin @ 2009-10-08 14:52 UTC (permalink / raw)
To: Avi Kivity; +Cc: Anthony Liguori, qemu-devel@nongnu.org, kvm-devel
On Wed, Oct 07, 2009 at 10:20:19AM +0200, Avi Kivity wrote:
>> Reset BARs and a couple of other registers on bus reset, as per PCI
>> spec.
>>
>
> This commit breaks Windows XP restart. After a restart Windows switches
> from 800x600 cirrus logic vga to 640x480 standard vga.
So I think this is a bios bug. Patchset fixing this applied.
So, what's the best way to propagate the fixes upstream?
Avi, Anthony, please advise.
Avi, after applying this, you need to generate a new bios binary.
Anthony, qemu keeps bios binaries in source tree.
I can't post a patch changing these, can I?
Only people with git access can change them.
BTW, can't we keep the sources around the like qemu-kvm does?
It would be best if pc-bios used git, then we would
include a submodule, as it is we can set up a git-cvs
mirror at qemu site, and then include a submodule.
Makes sense?
Michael S. Tsirkin (3):
pc-bios: enable io/memory unconditionally
qemu: make cirrus init value pci spec compliant
qemu: cleanup unused macros in cirrus
hw/cirrus_vga.c | 38 +-------------------------------------
kvm/bios/rombios32.c | 18 +++++++-----------
2 files changed, 8 insertions(+), 48 deletions(-)
--
MST
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 0/3] qemu: reset-related fixes
2009-10-08 14:52 ` [Qemu-devel] " Michael S. Tsirkin
@ 2009-10-08 15:02 ` Michael S. Tsirkin
-1 siblings, 0 replies; 6+ messages in thread
From: Michael S. Tsirkin @ 2009-10-08 15:02 UTC (permalink / raw)
To: Avi Kivity; +Cc: Anthony Liguori, qemu-devel@nongnu.org, kvm-devel
On Thu, Oct 08, 2009 at 04:52:26PM +0200, Michael S. Tsirkin wrote:
> On Wed, Oct 07, 2009 at 10:20:19AM +0200, Avi Kivity wrote:
> >> Reset BARs and a couple of other registers on bus reset, as per PCI
> >> spec.
> >>
> >
> > This commit breaks Windows XP restart. After a restart Windows switches
> > from 800x600 cirrus logic vga to 640x480 standard vga.
>
> So I think this is a bios bug. Patchset fixing this applied.
>
> So, what's the best way to propagate the fixes upstream?
> Avi, Anthony, please advise.
>
> Avi, after applying this, you need to generate a new bios binary.
>
> Anthony, qemu keeps bios binaries in source tree.
> I can't post a patch changing these, can I?
> Only people with git access can change them.
>
> BTW, can't we keep the sources around the like qemu-kvm does?
> It would be best if pc-bios used git, then we would
> include a submodule, as it is we can set up a git-cvs
> mirror at qemu site, and then include a submodule.
> Makes sense?
On this last point, it was pointed out to me that
this is what we have already. Sorry about the noise.
> Michael S. Tsirkin (3):
> pc-bios: enable io/memory unconditionally
> qemu: make cirrus init value pci spec compliant
> qemu: cleanup unused macros in cirrus
>
> hw/cirrus_vga.c | 38 +-------------------------------------
> kvm/bios/rombios32.c | 18 +++++++-----------
> 2 files changed, 8 insertions(+), 48 deletions(-)
>
> --
> MST
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Qemu-devel] Re: [PATCH 0/3] qemu: reset-related fixes
@ 2009-10-08 15:02 ` Michael S. Tsirkin
0 siblings, 0 replies; 6+ messages in thread
From: Michael S. Tsirkin @ 2009-10-08 15:02 UTC (permalink / raw)
To: Avi Kivity; +Cc: Anthony Liguori, qemu-devel@nongnu.org, kvm-devel
On Thu, Oct 08, 2009 at 04:52:26PM +0200, Michael S. Tsirkin wrote:
> On Wed, Oct 07, 2009 at 10:20:19AM +0200, Avi Kivity wrote:
> >> Reset BARs and a couple of other registers on bus reset, as per PCI
> >> spec.
> >>
> >
> > This commit breaks Windows XP restart. After a restart Windows switches
> > from 800x600 cirrus logic vga to 640x480 standard vga.
>
> So I think this is a bios bug. Patchset fixing this applied.
>
> So, what's the best way to propagate the fixes upstream?
> Avi, Anthony, please advise.
>
> Avi, after applying this, you need to generate a new bios binary.
>
> Anthony, qemu keeps bios binaries in source tree.
> I can't post a patch changing these, can I?
> Only people with git access can change them.
>
> BTW, can't we keep the sources around the like qemu-kvm does?
> It would be best if pc-bios used git, then we would
> include a submodule, as it is we can set up a git-cvs
> mirror at qemu site, and then include a submodule.
> Makes sense?
On this last point, it was pointed out to me that
this is what we have already. Sorry about the noise.
> Michael S. Tsirkin (3):
> pc-bios: enable io/memory unconditionally
> qemu: make cirrus init value pci spec compliant
> qemu: cleanup unused macros in cirrus
>
> hw/cirrus_vga.c | 38 +-------------------------------------
> kvm/bios/rombios32.c | 18 +++++++-----------
> 2 files changed, 8 insertions(+), 48 deletions(-)
>
> --
> MST
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 0/3] qemu: reset-related fixes
2009-10-08 14:52 ` [Qemu-devel] " Michael S. Tsirkin
@ 2009-10-08 15:16 ` Anthony Liguori
-1 siblings, 0 replies; 6+ messages in thread
From: Anthony Liguori @ 2009-10-08 15:16 UTC (permalink / raw)
To: Michael S. Tsirkin; +Cc: Avi Kivity, qemu-devel@nongnu.org, kvm-devel
Michael S. Tsirkin wrote:
> On Wed, Oct 07, 2009 at 10:20:19AM +0200, Avi Kivity wrote:
>
>>> Reset BARs and a couple of other registers on bus reset, as per PCI
>>> spec.
>>>
>>>
>> This commit breaks Windows XP restart. After a restart Windows switches
>> from 800x600 cirrus logic vga to 640x480 standard vga.
>>
>
> So I think this is a bios bug. Patchset fixing this applied.
>
> So, what's the best way to propagate the fixes upstream?
> Avi, Anthony, please advise.
>
> Avi, after applying this, you need to generate a new bios binary.
>
> Anthony, qemu keeps bios binaries in source tree.
> I can't post a patch changing these, can I?
> Only people with git access can change them.
>
> BTW, can't we keep the sources around the like qemu-kvm does?
> It would be best if pc-bios used git, then we would
> include a submodule, as it is we can set up a git-cvs
> mirror at qemu site, and then include a submodule.
> Makes sense?
>
This is exactly what we do. Look at roms/pc-bios.
--
Regards,
Anthony Liguori
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Qemu-devel] Re: [PATCH 0/3] qemu: reset-related fixes
@ 2009-10-08 15:16 ` Anthony Liguori
0 siblings, 0 replies; 6+ messages in thread
From: Anthony Liguori @ 2009-10-08 15:16 UTC (permalink / raw)
To: Michael S. Tsirkin; +Cc: Avi Kivity, kvm-devel, qemu-devel@nongnu.org
Michael S. Tsirkin wrote:
> On Wed, Oct 07, 2009 at 10:20:19AM +0200, Avi Kivity wrote:
>
>>> Reset BARs and a couple of other registers on bus reset, as per PCI
>>> spec.
>>>
>>>
>> This commit breaks Windows XP restart. After a restart Windows switches
>> from 800x600 cirrus logic vga to 640x480 standard vga.
>>
>
> So I think this is a bios bug. Patchset fixing this applied.
>
> So, what's the best way to propagate the fixes upstream?
> Avi, Anthony, please advise.
>
> Avi, after applying this, you need to generate a new bios binary.
>
> Anthony, qemu keeps bios binaries in source tree.
> I can't post a patch changing these, can I?
> Only people with git access can change them.
>
> BTW, can't we keep the sources around the like qemu-kvm does?
> It would be best if pc-bios used git, then we would
> include a submodule, as it is we can set up a git-cvs
> mirror at qemu site, and then include a submodule.
> Makes sense?
>
This is exactly what we do. Look at roms/pc-bios.
--
Regards,
Anthony Liguori
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2009-10-08 15:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-08 14:52 [PATCH 0/3] qemu: reset-related fixes Michael S. Tsirkin
2009-10-08 14:52 ` [Qemu-devel] " Michael S. Tsirkin
2009-10-08 15:02 ` Michael S. Tsirkin
2009-10-08 15:02 ` [Qemu-devel] " Michael S. Tsirkin
2009-10-08 15:16 ` Anthony Liguori
2009-10-08 15:16 ` [Qemu-devel] " Anthony Liguori
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.