All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Strakh <strakh@ispras.ru>
To: Pierre Ossman <pierre@ossman.eu>,
	sdhci-devel@lists.ossman.eu,
	Linux Kernlel Mailing List <linux-kernel@vger.kernel.org>
Subject: [BUG] wbsd.c: after spin_lock_bh uses spin_unlock instead spin_unlock_bh
Date: Thu, 8 Oct 2009 15:18:00 +0000	[thread overview]
Message-ID: <200910081518.00707.strakh@ispras.ru> (raw)

	KERNEL_VERSION: 2.6.31
	DESCRIBE:
Driver ./drivers/mmc/host/wbsd.c calls spin_lock_bh and then spin_unlock 
instead of spin_unlock_bh:

 753 static void wbsd_request(struct mmc_host *mmc, struct mmc_request *mrq)
...
 761         spin_lock_bh(&host->lock);
...
 844 done:
 845         wbsd_request_end(host, mrq);
 846
 847         spin_unlock_bh(&host->lock);
 848 }

But in wsdb_request calls spin_unlock/spin_lock instead of 
spin_unlock_bh/spin_lock_bh;

 206 static void wbsd_request_end(struct wbsd_host *host, struct mmc_request 
...
 230         spin_unlock(&host->lock);
 231         mmc_request_done(host->mmc, mrq);
 232         spin_lock(&host->lock);
 233 }

Found by : Linux Driver Verification

             reply	other threads:[~2009-10-08 11:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-08 15:18 Alexander Strakh [this message]
2009-10-08 18:20 ` [BUG] wbsd.c: after spin_lock_bh uses spin_unlock instead spin_unlock_bh Peter Zijlstra
2009-10-08 18:35 ` Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200910081518.00707.strakh@ispras.ru \
    --to=strakh@ispras.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pierre@ossman.eu \
    --cc=sdhci-devel@lists.ossman.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.