From: Stuart Brady <sdbrady@ntlworld.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] eepro100: Remove unused device status entries
Date: Thu, 8 Oct 2009 20:00:31 +0100 [thread overview]
Message-ID: <20091008190031.GA3496@miranda.arrow> (raw)
In-Reply-To: <1254982537-6377-1-git-send-email-weil@mail.berlios.de>
On Thu, Oct 08, 2009 at 08:15:37AM +0200, Stefan Weil wrote:
[snip entertaining patch description]
> - if (version_id >= 2) {
> - qemu_get_8s(f, &s->rxcr);
> - } else {
> - s->rxcr = 0x0c;
> - }
> + /* Skip unused entries. */
> + qemu_fseek(f, 32, SEEK_CUR);
Shouldn't the number of bytes skipped depend on the version ID?
Cheers,
--
Stuart Brady
next prev parent reply other threads:[~2009-10-08 18:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-19 11:41 [Qemu-devel] [PATCH] eepro100: Remove unused device status entries Stefan Weil
[not found] ` <m3d45naqws.fsf@neno.mitica>
2009-09-19 15:58 ` [Qemu-devel] " Stefan Weil
2009-10-05 13:20 ` Anthony Liguori
2009-10-08 6:15 ` [Qemu-devel] " Stefan Weil
2009-10-08 19:00 ` Stuart Brady [this message]
2009-10-08 19:19 ` Stefan Weil
2009-10-09 17:49 ` Stefan Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091008190031.GA3496@miranda.arrow \
--to=sdbrady@ntlworld.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.