From: Ralf Baechle <ralf@linux-mips.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Wu Zhangjin <wuzhangjin@gmail.com>,
linux-mips@linux-mips.org,
Sergei Shtylyov <sshtylyov@ru.mvista.com>,
Pavel Machek <pavel@ucw.cz>
Subject: Re: [PATCH -v1] MIPS: fix pfn_valid() for FLATMEM
Date: Thu, 8 Oct 2009 22:44:47 +0200 [thread overview]
Message-ID: <20091008204447.GA14560@linux-mips.org> (raw)
In-Reply-To: <200910082221.12649.rjw@sisk.pl>
On Thu, Oct 08, 2009 at 10:21:12PM +0200, Rafael J. Wysocki wrote:
> > Here, we fix it via checking pfn is in the "System RAM" or not. and
> > Seems pfn_valid() is not called in assembly code, we move it to
> > "!__ASSEMBLY__" to ensure we can simply declare it via "extern int
> > pfn_valid(unsigned long)" without Compiling Error.
> >
> > (This -v1 version incorporates feedback from Pavel Machek <pavel@ucw.cz>
> > and Sergei Shtylyov <sshtylyov@ru.mvista.com>)
>
> Hmm. What exactly would be wrong with using register_nosave_region() or
> register_nosave_region_late() like x86 does?
That seems to be more the fix than pfn_valid / PageReserved fiddlery we were
discussing in the other thread. Thanks!
Ralf
next prev parent reply other threads:[~2009-10-08 20:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-08 11:32 [PATCH -v1] MIPS: fix pfn_valid() for FLATMEM Wu Zhangjin
2009-10-08 20:21 ` Rafael J. Wysocki
2009-10-08 20:44 ` Ralf Baechle [this message]
2009-10-09 2:08 ` Wu Zhangjin
2009-10-09 16:02 ` Wu Zhangjin
2009-10-13 22:04 ` Ralf Baechle
2009-10-14 1:06 ` Wu Zhangjin
-- strict thread matches above, loose matches on Subject: below --
2009-10-09 16:15 Wu Zhangjin
2009-10-09 16:20 ` Wu Zhangjin
2009-10-10 14:38 ` Wu Zhangjin
2009-10-10 19:19 ` Wu Zhangjin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091008204447.GA14560@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=linux-mips@linux-mips.org \
--cc=pavel@ucw.cz \
--cc=rjw@sisk.pl \
--cc=sshtylyov@ru.mvista.com \
--cc=wuzhangjin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.