From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Serge E. Hallyn" Subject: Re: [PATCH 1/1] cr: lsm: actually cache entries Date: Thu, 8 Oct 2009 16:41:11 -0500 Message-ID: <20091008214111.GA7588@us.ibm.com> References: <20091008194720.GA648@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20091008194720.GA648-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Linux Containers List-Id: containers.vger.kernel.org Quoting Serge E. Hallyn (serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org): > Somewhere along the way, the lsm c/r patchset seems to have > dropped the code caching whether a particular void*security > had already been checkpointed. Note that checkpoint a > void* security means allocing a struct containing the secref > and the string representation of the context. That leaves us > with no way to tell, given only the void*security, whether > that context has been checkpointed before (as part of checkpointing > a different object of the same object type and security context). > > This patch re-introduces a moronic unsorted per-checkpoint list > of checkpointed contexts, used only at checkpoint time, so that > we can re-use secrefs. Converting this to an rblist or hash will > be trivial, but isn't done here to try and make clear why we > actually need this. > > (applies on top of existing LSM c/r patches at > git://git.kernel.org/pub/scm/linux/kernel/git/sergeh/linux-cr.git) > > Signed-off-by: Serge E. Hallyn Matt called me on this over irc, and as a result I think I've found a trivial way to do this much better... pls ignore for now. thanks, -serge