From mboxrd@z Thu Jan  1 00:00:00 1970
From: Simon Horman <horms@verge.net.au>
Subject: Re: Possible bug with pass-through hot-plug?
Date: Fri, 9 Oct 2009 09:36:45 +1100
Message-ID: <20091008223642.GA8690@verge.net.au>
References: <8686c3cd0910070200r7f3c59d9o8964ea432372a6b2@mail.gmail.com>
	<20091007093840.GB18775@verge.net.au>
	<8686c3cd0910070256p77f58aeat23aea646aaf82b86@mail.gmail.com>
	<20091007120246.GA5088@verge.net.au>
	<8686c3cd0910070828v30b1838by29c592bfb18f27c1@mail.gmail.com>
	<8686c3cd0910070841t2dd45aebx2f8a047477807e41@mail.gmail.com>
	<20091007225211.GD2055@verge.net.au>
	<20091007234132.GE2055@verge.net.au>
	<8686c3cd0910080655lc74ac21o644d9c88cb6bddcb@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <xen-devel-bounces@lists.xensource.com>
Content-Disposition: inline
In-Reply-To: <8686c3cd0910080655lc74ac21o644d9c88cb6bddcb@mail.gmail.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Tom Rotenberg <tom.rotenberg@gmail.com>
Cc: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

Hi Tom,

On Thu, Oct 08, 2009 at 03:55:21PM +0200, Tom Rotenberg wrote:
> The qemu xen i tested today, (which aslo doesn't work), is:
> --------------------------------------------------------------
> commit a05958b6e32f1748ea70b1efca13394956c0698b
> Author: Ian Jackson <ian.jackson@eu.citrix.com>
> Date:   Wed Oct 7 15:57:18 2009 +0100
> 
>     block: Clean up after deleting BHs
> --------------------------------------------------------------
> 
> Here are the log results you wanted (without my change):
> 
> dm-command: hot insert pass-through pci dev
> insert_to_pci_devfn: bdf_slt="0000:00:1b.0@100"

The 100 is the problem. If you are using slot 1b (and function 0)
then it should be:

	PCI_DEVFN(1b,0) = (1b << 3) + 0) = d8

Slot values with bit 9 set (that is >= 0x100) are used to tell
qemu-xen to choose a slot. Is your pass-through device showing
up in the guest at all, for instance in some low virtual slot like 4?

The 100 should be originating from parse_pci_name_extended() which
is called by xm for hot-plug and xend for boot-time assignment.
Instrumenting the callers of that function might help to shed some light
on the problem.

Lastly, could you post the syntax you are using to pass-through
the device? Is possible that my tests aren't covering your case.