From: Tony Lindgren <tony@atomide.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mmc@vger.kernel.org, linux-omap@vger.kernel.org,
"Madhusudhan Chikkature" <madhu.cr@ti.com>,
"Felipe Contreras" <felipe.contreras@gmail.com>,
"Adrian Hunter" <adrian.hunter@nokia.com>,
"Roger Quadros" <ext-roger.quadros@nokia.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Denis Karpov" <ext-denis.2.karpov@nokia.com>
Subject: [PATCH] omap_hsmmc: Add missing probe handler hook
Date: Thu, 8 Oct 2009 15:54:28 -0700 [thread overview]
Message-ID: <20091008225428.GA25892@atomide.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 393 bytes --]
Andrew,
Here's a fix from Roger Quadros that was accidentally not posted
to linux-mmc as pointed out by Felipe Contreras on LKML.
Can you please pick it up?
For reference, this is the issue Uwe Kleine-König mentioned at:
http://www.mail-archive.com/linux-mmc@vger.kernel.org/msg00528.html
Felipe Contreras summarized how things broke at:
http://lkml.org/lkml/2009/10/8/334
Regards,
Tony
[-- Attachment #2: v2-omap_hsmmc-Add-missing-probe-handler-hook.patch --]
[-- Type: text/x-diff, Size: 1202 bytes --]
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: [v2] omap_hsmmc: Add missing probe handler hook
Date: Fri, 02 Oct 2009 12:22:40 -0000
From: Roger Quadros <ext-roger.quadros@nokia.com>
X-Patchwork-Id: 51344
The missing probe handler hook will never probe the driver. Add it back.
Fixes broken MMC on OMAP.
We use platform_driver_probe() API since omap_hsmmc is not a hot-pluggable
device.
Signed-off-by: Roger Quadros <ext-roger.quadros@nokia.com>
Tested-by: Felipe Contreras <felipe.contreras@gmail.com>
Tested-by: Tony Lindgren <tony@atomide.com>
---
drivers/mmc/host/omap_hsmmc.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
index 4487cc0..0aecaae 100644
--- a/drivers/mmc/host/omap_hsmmc.c
+++ b/drivers/mmc/host/omap_hsmmc.c
@@ -2013,7 +2013,7 @@ static struct platform_driver omap_hsmmc_driver = {
static int __init omap_hsmmc_init(void)
{
/* Register the MMC driver */
- return platform_driver_register(&omap_hsmmc_driver);
+ return platform_driver_probe(&omap_hsmmc_driver, omap_hsmmc_probe);
}
static void __exit omap_hsmmc_cleanup(void)
reply other threads:[~2009-10-08 22:54 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091008225428.GA25892@atomide.com \
--to=tony@atomide.com \
--cc=adrian.hunter@nokia.com \
--cc=akpm@linux-foundation.org \
--cc=ext-denis.2.karpov@nokia.com \
--cc=ext-roger.quadros@nokia.com \
--cc=felipe.contreras@gmail.com \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=madhu.cr@ti.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.