All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: linux-kernel@vger.kernel.org,
	"Denis Karpov" <ext-denis.2.karpov@nokia.com>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	linux-omap@vger.kernel.org,
	"Linus Torvalds" <torvalds@linux-foundation.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [GIT PULL] omap fixes for v2.6.32-rc3
Date: Thu, 8 Oct 2009 16:26:03 -0700	[thread overview]
Message-ID: <20091008232603.GB25892@atomide.com> (raw)
In-Reply-To: <94a0d4530910081520t66ce7567xe142979a35b1245@mail.gmail.com>

* Felipe Contreras <felipe.contreras@gmail.com> [091008 15:20]:
> On Fri, Oct 9, 2009 at 1:13 AM, Felipe Contreras
> <felipe.contreras@gmail.com> wrote:
> > On Fri, Oct 9, 2009 at 12:41 AM, Tony Lindgren <tony@atomide.com> wrote:
> >> * Felipe Contreras <felipe.contreras@gmail.com> [091008 14:29]:
> >>> On Wed, Oct 7, 2009 at 9:51 PM, Tony Lindgren <tony@atomide.com> wrote:
> >>>

<snip snip>

> >>> The beagleboard is still not booting for me with this branch, I need
> >>> to add these two patches:
> >>>
> >>> * http://patchwork.kernel.org/patch/50721/
> >>>
> >>
> >> This should go to the mainline kernel via Samuel as it's
> >> drivers/mfd related.
> >>
> >>> This one is needed because the defconfig has:
> >>> CONFIG_TWL4030_USB=y
> >>>
> >>> * http://patchwork.kernel.org/patch/50970/
> >>>
> >>> This is needed because most people boot from an MMC.
> >>
> >> And this should go in via the mmc list.
> >
> > Should it?
> >
> > Here you can see Uwe Kleine-König sending the original patch without
> > even CC'ing the mmc list:
> > http://marc.info/?l=linux-kernel&m=124820861213849&w=2
> >
> > And it was unintentionally broken by this one:
> > http://marc.info/?l=linux-mmc&m=125249763422227&w=2
> 
> Er, actually that one was ok, the problem was introduced only in the
> final version:
> http://marc.info/?l=linux-mmc&m=125366315417006&w=2

Right, looks like Roger forgot to Cc linux-mmc.
 
> > I don't see what we are waiting for, the code is clearly broken, even
> > the compiler warns that nobody is using omap_hsmmc_probe().

I've sent Roger's patch to Andrew & linux-mmc so hopefully it will get
merged soon:

http://www.mail-archive.com/linux-mmc@vger.kernel.org/msg00539.html

Regards,

Tony

WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [GIT PULL] omap fixes for v2.6.32-rc3
Date: Thu, 8 Oct 2009 16:26:03 -0700	[thread overview]
Message-ID: <20091008232603.GB25892@atomide.com> (raw)
In-Reply-To: <94a0d4530910081520t66ce7567xe142979a35b1245@mail.gmail.com>

* Felipe Contreras <felipe.contreras@gmail.com> [091008 15:20]:
> On Fri, Oct 9, 2009 at 1:13 AM, Felipe Contreras
> <felipe.contreras@gmail.com> wrote:
> > On Fri, Oct 9, 2009 at 12:41 AM, Tony Lindgren <tony@atomide.com> wrote:
> >> * Felipe Contreras <felipe.contreras@gmail.com> [091008 14:29]:
> >>> On Wed, Oct 7, 2009 at 9:51 PM, Tony Lindgren <tony@atomide.com> wrote:
> >>>

<snip snip>

> >>> The beagleboard is still not booting for me with this branch, I need
> >>> to add these two patches:
> >>>
> >>> * http://patchwork.kernel.org/patch/50721/
> >>>
> >>
> >> This should go to the mainline kernel via Samuel as it's
> >> drivers/mfd related.
> >>
> >>> This one is needed because the defconfig has:
> >>> CONFIG_TWL4030_USB=y
> >>>
> >>> * http://patchwork.kernel.org/patch/50970/
> >>>
> >>> This is needed because most people boot from an MMC.
> >>
> >> And this should go in via the mmc list.
> >
> > Should it?
> >
> > Here you can see Uwe Kleine-K?nig sending the original patch without
> > even CC'ing the mmc list:
> > http://marc.info/?l=linux-kernel&m=124820861213849&w=2
> >
> > And it was unintentionally broken by this one:
> > http://marc.info/?l=linux-mmc&m=125249763422227&w=2
> 
> Er, actually that one was ok, the problem was introduced only in the
> final version:
> http://marc.info/?l=linux-mmc&m=125366315417006&w=2

Right, looks like Roger forgot to Cc linux-mmc.
 
> > I don't see what we are waiting for, the code is clearly broken, even
> > the compiler warns that nobody is using omap_hsmmc_probe().

I've sent Roger's patch to Andrew & linux-mmc so hopefully it will get
merged soon:

http://www.mail-archive.com/linux-mmc at vger.kernel.org/msg00539.html

Regards,

Tony

WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: "Linus Torvalds" <torvalds@linux-foundation.org>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
	"Denis Karpov" <ext-denis.2.karpov@nokia.com>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Subject: Re: [GIT PULL] omap fixes for v2.6.32-rc3
Date: Thu, 8 Oct 2009 16:26:03 -0700	[thread overview]
Message-ID: <20091008232603.GB25892@atomide.com> (raw)
In-Reply-To: <94a0d4530910081520t66ce7567xe142979a35b1245@mail.gmail.com>

* Felipe Contreras <felipe.contreras@gmail.com> [091008 15:20]:
> On Fri, Oct 9, 2009 at 1:13 AM, Felipe Contreras
> <felipe.contreras@gmail.com> wrote:
> > On Fri, Oct 9, 2009 at 12:41 AM, Tony Lindgren <tony@atomide.com> wrote:
> >> * Felipe Contreras <felipe.contreras@gmail.com> [091008 14:29]:
> >>> On Wed, Oct 7, 2009 at 9:51 PM, Tony Lindgren <tony@atomide.com> wrote:
> >>>

<snip snip>

> >>> The beagleboard is still not booting for me with this branch, I need
> >>> to add these two patches:
> >>>
> >>> * http://patchwork.kernel.org/patch/50721/
> >>>
> >>
> >> This should go to the mainline kernel via Samuel as it's
> >> drivers/mfd related.
> >>
> >>> This one is needed because the defconfig has:
> >>> CONFIG_TWL4030_USB=y
> >>>
> >>> * http://patchwork.kernel.org/patch/50970/
> >>>
> >>> This is needed because most people boot from an MMC.
> >>
> >> And this should go in via the mmc list.
> >
> > Should it?
> >
> > Here you can see Uwe Kleine-König sending the original patch without
> > even CC'ing the mmc list:
> > http://marc.info/?l=linux-kernel&m=124820861213849&w=2
> >
> > And it was unintentionally broken by this one:
> > http://marc.info/?l=linux-mmc&m=125249763422227&w=2
> 
> Er, actually that one was ok, the problem was introduced only in the
> final version:
> http://marc.info/?l=linux-mmc&m=125366315417006&w=2

Right, looks like Roger forgot to Cc linux-mmc.
 
> > I don't see what we are waiting for, the code is clearly broken, even
> > the compiler warns that nobody is using omap_hsmmc_probe().

I've sent Roger's patch to Andrew & linux-mmc so hopefully it will get
merged soon:

http://www.mail-archive.com/linux-mmc@vger.kernel.org/msg00539.html

Regards,

Tony

  reply	other threads:[~2009-10-08 23:26 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-07 18:51 [GIT PULL] omap fixes for v2.6.32-rc3 Tony Lindgren
2009-10-07 18:51 ` Tony Lindgren
2009-10-07 18:51 ` Tony Lindgren
2009-10-08 21:29 ` Felipe Contreras
2009-10-08 21:29   ` Felipe Contreras
2009-10-08 21:29   ` Felipe Contreras
2009-10-08 21:41   ` Tony Lindgren
2009-10-08 21:41     ` Tony Lindgren
2009-10-08 21:41     ` Tony Lindgren
2009-10-08 22:13     ` Felipe Contreras
2009-10-08 22:13       ` Felipe Contreras
2009-10-08 22:13       ` Felipe Contreras
2009-10-08 22:20       ` Felipe Contreras
2009-10-08 22:20         ` Felipe Contreras
2009-10-08 22:20         ` Felipe Contreras
2009-10-08 23:26         ` Tony Lindgren [this message]
2009-10-08 23:26           ` Tony Lindgren
2009-10-08 23:26           ` Tony Lindgren
2009-10-09 12:08           ` Felipe Contreras
2009-10-09 14:48             ` Greg KH
2009-10-09 17:29               ` Felipe Contreras
2009-10-09 19:26                 ` Greg KH
2009-10-09 21:33                   ` Andrew Morton
2009-10-10 10:38                     ` Felipe Contreras
2009-10-10 10:38                       ` Felipe Contreras
2009-10-09 21:42                   ` Jiri Kosina
2009-10-09 21:57                     ` Andrew Morton
2009-10-09 22:32                     ` Madhusudhan
2009-10-09 22:32                       ` Madhusudhan
2009-10-09  8:02       ` Uwe Kleine-König
2009-10-09  8:02         ` Uwe Kleine-König
2009-10-09  8:02         ` Uwe Kleine-König
2009-10-09  8:25         ` Felipe Contreras
2009-10-09  8:25           ` Felipe Contreras
2009-10-09  8:25           ` Felipe Contreras
2009-10-09  8:30           ` Uwe Kleine-König
2009-10-09  8:30             ` Uwe Kleine-König
2009-10-09  8:30             ` Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091008232603.GB25892@atomide.com \
    --to=tony@atomide.com \
    --cc=ext-denis.2.karpov@nokia.com \
    --cc=felipe.contreras@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.