From: Paul Mundt <lethal@linux-sh.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] sh: sh7785lcr: add possibility of using 128MB pci window on sh7785lcr by using PMB
Date: Fri, 09 Oct 2009 01:31:19 +0000 [thread overview]
Message-ID: <20091009013118.GC31816@linux-sh.org> (raw)
In-Reply-To: <4ACDB6B8.9090808@siemens.com>
On Thu, Oct 08, 2009 at 01:54:00PM +0400, Valentin R Sitsikov wrote:
> Only pci may start now from 0xC0000000-phys:0xb8000000-virtual.
> All other mapping is the same as without using PMB.
>
> Signed-off-by: Valentin Sitdikov <valentin.sitdikov@siemens.com>
No, we are not going to add any ifdefs to vary the size of the PCI memory
window. A lot of hard work went in to throwing away all of this ifdef
configuration crap in the first place, and the last thing we want to do
is reinstate more of it. We do not have enough address space with or
without the PMB to make varying configurations realistic.
Having said that, I think 128MB is a fine default, given that presently
we are completely starved for vmalloc space due to the mindless
assignment of PCI memory to that region. As such, perhaps the easiest
thing to do is simply to scale the window size back to 128MB as a maximum
and bump vmalloc space after that (or even 64MB for PCI memory would
probably be fine).
If anyone wants to map more PCI memory than that, they are not going to
be able to use the legacy P1/P2 mappings. We would be better off throwing
out P2 completely and giving it over to sparsemem vmemmap to actually do
something useful with anyways.
next prev parent reply other threads:[~2009-10-09 1:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-08 9:54 [PATCH] sh: sh7785lcr: add possibility of using 128MB pci window Valentin R Sitsikov
2009-10-09 1:31 ` Paul Mundt [this message]
2009-10-15 11:26 ` Valentin R Sitsikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091009013118.GC31816@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.