All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2 1/3] memcpy: copy one word at a time	if	possible
Date: Fri, 9 Oct 2009 06:26:58 -0400	[thread overview]
Message-ID: <200910090627.00401.vapier@gentoo.org> (raw)
In-Reply-To: <4ACF0C44.9040101@mimc.co.uk>

On Friday 09 October 2009 06:11:16 Mark Jackson wrote:
> Chris Moore wrote:
> > I agree wholeheartedly with the idea but shouldn't it be more like this
> > (untested) code :
> >
> > void * memcpy(void *dest, const void *src, size_t count)
> >
> > {
> > 	char *d8, *s8;
> > 	unsigned long *dl = dest, *sl = src;
> 
> In here, would it be overkill to add byte copying until data is aligned,
>  and then fall into the aligned copy code.

both addresses have to be unaligned the same ...

if ((ulong)dl & (sizeof(*dl) - 1) == (ulong)sl & (sizeof(*sl) - 1))

> In that case, you'd still gain a speed increase if you're starting at an
>  unaligned address ?

now it's a question of how often does this come up and is it worth the code 
size increase ?
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20091009/fe1b4c85/attachment.pgp 

  reply	other threads:[~2009-10-09 10:26 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-08 11:29 [U-Boot] [PATCH V2 0/3] make memcpy and memset faster Alessandro Rubini
2009-10-08 11:30 ` [U-Boot] [PATCH V2 1/3] memcpy: copy one word at a time if possible Alessandro Rubini
2009-10-08 15:12   ` Peter Tyser
2009-10-08 16:00     ` Alessandro Rubini
2009-10-08 16:30       ` Peter Tyser
2009-10-08 18:23         ` Alessandro Rubini
2009-10-08 19:09           ` Peter Tyser
2009-10-08 19:17             ` Alessandro Rubini
2009-10-08 20:40               ` Wolfgang Denk
2009-10-08 20:47       ` Wolfgang Denk
2009-10-08 19:14   ` Mike Frysinger
2009-10-08 20:44   ` Wolfgang Denk
2009-10-09  4:42     ` Chris Moore
2009-10-09 10:11       ` Mark Jackson
2009-10-09 10:26         ` Mike Frysinger [this message]
2009-10-11  7:06           ` Chris Moore
2009-10-09 11:12       ` Wolfgang Denk
2009-10-08 11:30 ` [U-Boot] [PATCH V2 2/3] memset: fill " Alessandro Rubini
2009-10-08 20:46   ` Wolfgang Denk
2009-10-08 11:30 ` [U-Boot] [PATCH V2 3/3] lcd: remove '#if 0' 32-bit scroll, now memcpy does it Alessandro Rubini
2009-11-22 22:34   ` Wolfgang Denk
2009-11-24 23:04     ` Anatolij Gustschin
2009-10-08 20:36 ` [U-Boot] [PATCH V2 0/3] make memcpy and memset faster Wolfgang Denk
2009-10-08 21:30 ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200910090627.00401.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.