From mboxrd@z Thu Jan  1 00:00:00 1970
From: Simon Horman <horms@verge.net.au>
Subject: Re: Possible bug with pass-through hot-plug?
Date: Fri, 9 Oct 2009 20:07:43 +1100
Message-ID: <20091009090743.GC7390@verge.net.au>
References: <8686c3cd0910070256p77f58aeat23aea646aaf82b86@mail.gmail.com>
	<20091007120246.GA5088@verge.net.au>
	<8686c3cd0910070828v30b1838by29c592bfb18f27c1@mail.gmail.com>
	<8686c3cd0910070841t2dd45aebx2f8a047477807e41@mail.gmail.com>
	<20091007225211.GD2055@verge.net.au>
	<20091007234132.GE2055@verge.net.au>
	<8686c3cd0910080655lc74ac21o644d9c88cb6bddcb@mail.gmail.com>
	<20091008223642.GA8690@verge.net.au>
	<8686c3cd0910090136v633b1275k7d58c55a3645da65@mail.gmail.com>
	<20091009085918.GB7390@verge.net.au>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <xen-devel-bounces@lists.xensource.com>
Content-Disposition: inline
In-Reply-To: <20091009085918.GB7390@verge.net.au>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Tom Rotenberg <tom.rotenberg@gmail.com>
Cc: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

On Fri, Oct 09, 2009 at 07:59:18PM +1100, Simon Horman wrote:
> On Fri, Oct 09, 2009 at 10:36:07AM +0200, Tom Rotenberg wrote:
> > Simon,
> > 
> > I think u missed something here... in the regular state, when u do:
> > xm create hvm pci='00:1b.0'
> > 
> > then the device is being assigned the 0x100 slot, which means - qemu
> > will auto-assign the slot.
> > In this case - the hot-remove works fine.
> > 
> > In the other method i tried, when i wanted to register the device on a
> > specific slot (00:1b.0), (in order to reproduce it - u can change
> > qemu to force the devfn to be 1b.0, as i sent in my first mail) - in
> > that case, the device is assigned the slot 00:1b.0, and i see in the
> > Windows device manager, that it got the virtual slot 00:1b.0
> > Now, when i try to hot-remove the device - it doesn't work.
> 
> Ok, I missed that. Without your change does the device appear in the
> device manager? If not could you try my debugging patch and see what it
> reports.
> 
> > Doesn't it reproduce to u? (with the patch i sent, for forcing devfn
> > to be 00:1b.0) ?
> 
> I am able to hot-plug devices into specific slots without your change.
> I'll verify that hot-unplug also works.

hot-unplug is working for me

> N.B: My guests are linux not Windows.
> Although I don't think that makes any difference.