From: Ralf Baechle <ralf@linux-mips.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Wu Zhangjin <wuzhangjin@gmail.com>, Arnd Bergmann <arnd@arndb.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Remis Lima Baima <remis.developer@googlemail.com>,
Christoph Hellwig <hch@lst.de>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>
Subject: [PATCH] IRQ: Change __softirq_pending to unsigned int in asm-generic/hardirq.h.
Date: Fri, 9 Oct 2009 12:41:30 +0200 [thread overview]
Message-ID: <20091009104130.GB619@linux-mips.org> (raw)
In-Reply-To: <20091009102814.GA619@linux-mips.org>
Since the beginnings in aafe4dbed0bf6cbdb2e9f03e1d42f8a540d8541d
include/asm-generic/hardirq.h defined __softirq_pending as unsigned long
which is different from other architectures for no apparent good reason
and was causing the following warning:
kernel/time/tick-sched.c: In function 'tick_nohz_stop_sched_tick':
kernel/time/tick-sched.c:261: warning: format '%02x' expects type 'unsigned int', but argument 2 has type 'long unsigned int'
Reported and initial patch by Wu Zhangjin <wuzhangjin@gmail.com>.
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
---
Tested on a big endian 64-bit MIPS SMP system.
include/asm-generic/hardirq.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/asm-generic/hardirq.h b/include/asm-generic/hardirq.h
index 23bb4da..62f5908 100644
--- a/include/asm-generic/hardirq.h
+++ b/include/asm-generic/hardirq.h
@@ -6,7 +6,7 @@
#include <linux/irq.h>
typedef struct {
- unsigned long __softirq_pending;
+ unsigned int __softirq_pending;
} ____cacheline_aligned irq_cpustat_t;
#include <linux/irq_cpustat.h> /* Standard mappings for irq_cpustat_t above */
next prev parent reply other threads:[~2009-10-09 10:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-08 14:46 [PATCH] kernel/time/tick-sched.c: fix warning of printk's argument format Wu Zhangjin
2009-10-08 15:03 ` Linus Torvalds
2009-10-08 15:31 ` Wu Zhangjin
2009-10-09 6:56 ` Yong Zhang
2009-10-09 10:28 ` Ralf Baechle
2009-10-09 10:41 ` Ralf Baechle [this message]
[not found] ` <200910091542.29457.arnd@arndb.de>
2009-10-09 21:41 ` Helge Deller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091009104130.GB619@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=remis.developer@googlemail.com \
--cc=torvalds@linux-foundation.org \
--cc=wuzhangjin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.