From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MwKAH-0000uY-6H for mharc-grub-devel@gnu.org; Fri, 09 Oct 2009 14:26:05 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MwKAF-0000sA-4d for grub-devel@gnu.org; Fri, 09 Oct 2009 14:26:03 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MwKAA-0000kg-B3 for grub-devel@gnu.org; Fri, 09 Oct 2009 14:26:02 -0400 Received: from [199.232.76.173] (port=58870 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MwKAA-0000kI-3a for grub-devel@gnu.org; Fri, 09 Oct 2009 14:25:58 -0400 Received: from xvm-190-8.ghst.net ([217.70.190.8]:49854 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MwKA9-0006zV-KW for grub-devel@gnu.org; Fri, 09 Oct 2009 14:25:57 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1MwKA6-0000xN-KI for grub-devel@gnu.org; Fri, 09 Oct 2009 20:25:54 +0200 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1MwKA5-00027G-WD for grub-devel@gnu.org; Fri, 09 Oct 2009 20:25:54 +0200 Date: Fri, 9 Oct 2009 20:25:53 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20091009182553.GD4645@thorin> References: <20091007211334.GA31055@thorin> <4ACE7154.9020405@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4ACE7154.9020405@gmail.com> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: [PATCH] Fail gracefuly when attempting to load 64-bit kFreeBSD on IA32 CPU X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Oct 2009 18:26:03 -0000 Hi, I didn't notice this mail untill a few minutes ago (was still in fetch queue), so my first patch was already checked in. On Fri, Oct 09, 2009 at 01:10:12AM +0200, Vladimir 'phcoder' Serbinenko wrote: > >Index: include/grub/i386/cpuid.h > >=================================================================== > >--- include/grub/i386/cpuid.h (revision 0) > >+++ include/grub/i386/cpuid.h (revision 0) > > This file doesn't follow convention of having an ifdef around the file Thanks, I've added it now. > >+extern unsigned char grub_cpuid_has_longmode; > I don't like it being declared as a variable: user may inadvertently assign a value to it. I would be more confortable with a function I tend to prefer a (const) function too, but this required some restructuring in cpuid.c so for 1.97 I opted for keeping the changes minimal. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."