From: Pavel Machek <pavel@ucw.cz>
To: Christoph Hellwig <hch@infradead.org>
Cc: kernel list <linux-kernel@vger.kernel.org>, Greg KH <greg@kroah.com>
Subject: Re: staging: where to put system-wide includes
Date: Fri, 9 Oct 2009 22:38:02 +0200 [thread overview]
Message-ID: <20091009203802.GD2040@elf.ucw.cz> (raw)
In-Reply-To: <20091008184027.GA5890@infradead.org>
On Thu 2009-10-08 14:40:27, Christoph Hellwig wrote:
> On Thu, Oct 08, 2009 at 01:28:18PM +0200, Pavel Machek wrote:
> > Hi!
> >
> > In staging, I need some includes that will become "system-wide" at the
> > end.
> >
> > Is it acceptable to create drivers/staging/include/linux (and
> > friends), and then use -I magic to include those headers?
>
> If you need system-wide inclusions it's pretty good sign that what
> you add is not a simple driver and thus should not just go into the
> staging tree. Given that you're a long-timer kernel hackers what's the
> problem with getting your code fully up to kernel standards anyway?
Well, it is not exactly my code -- I'm trying to merge HTC Dream
support. Problem with "simply cleaning it up" is that its 122Kloc.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
prev parent reply other threads:[~2009-10-09 20:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-08 11:28 staging: where to put system-wide includes Pavel Machek
2009-10-08 15:00 ` Greg KH
2009-10-17 18:26 ` Pavel Machek
2009-10-08 18:40 ` Christoph Hellwig
2009-10-09 20:38 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091009203802.GD2040@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=greg@kroah.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.