All of lore.kernel.org
 help / color / mirror / Atom feed
From: akpm@linux-foundation.org
To: david.vrabel@csr.com, bzhao@marvell.com, jic23@cam.ac.uk,
	linux-mmc@vger.kernel.org, roel.kluin@gmail.com,
	mm-commits@vger.kernel.org
Subject: [merged] mmc-sdio-dont-require-cistpl_vers_1-to-contain-4-strings.patch removed from -mm tree
Date: Fri, 09 Oct 2009 15:05:18 -0700	[thread overview]
Message-ID: <200910092205.n99M5Ivx021129@imap1.linux-foundation.org> (raw)


The patch titled
     mmc: sdio: don't require CISTPL_VERS_1 to contain 4 strings
has been removed from the -mm tree.  Its filename was
     mmc-sdio-dont-require-cistpl_vers_1-to-contain-4-strings.patch

This patch was dropped because it was merged into mainline or a subsystem tree

The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/

------------------------------------------------------
Subject: mmc: sdio: don't require CISTPL_VERS_1 to contain 4 strings
From: David Vrabel <david.vrabel@csr.com>

The PC Card 8.0 specification (vol.  4, section 3.2.10) says the
TPLLV1_INFO field of the CISTPL_VERS_1 tuple must contain 4 strings.  Some
cards don't have all 4 so just parse as many as we can.

[akpm@linux-foundation.org: coding-style fixes]
Signed-off-by: David Vrabel <david.vrabel@csr.com>
Tested-by: Jonathan Cameron <jic23@cam.ac.uk>
Tested-by: Bing Zhao <bzhao@marvell.com>
Cc: Roel Kluin <roel.kluin@gmail.com>
Cc: <linux-mmc@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---


diff -puN drivers/mmc/core/sdio_cis.c~mmc-sdio-dont-require-cistpl_vers_1-to-contain-4-strings drivers/mmc/core/sdio_cis.c
--- a/drivers/mmc/core/sdio_cis.c~mmc-sdio-dont-require-cistpl_vers_1-to-contain-4-strings
+++ a/drivers/mmc/core/sdio_cis.c
@@ -29,6 +29,8 @@ static int cistpl_vers_1(struct mmc_card
 	unsigned i, nr_strings;
 	char **buffer, *string;
 
+	/* Find all null-terminated (including zero length) strings in
+	   the TPLLV1_INFO field. Trailing garbage is ignored. */
 	buf += 2;
 	size -= 2;
 
@@ -39,11 +41,8 @@ static int cistpl_vers_1(struct mmc_card
 		if (buf[i] == 0)
 			nr_strings++;
 	}
-
-	if (nr_strings < 4) {
-		printk(KERN_WARNING "SDIO: ignoring broken CISTPL_VERS_1\n");
+	if (nr_strings == 0)
 		return 0;
-	}
 
 	size = i;
 
_

Patches currently in -mm which might be from david.vrabel@csr.com are

origin.patch


             reply	other threads:[~2009-10-09 22:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-09 22:05 akpm [this message]
  -- strict thread matches above, loose matches on Subject: below --
2009-10-09 22:05 [merged] mmc-sdio-dont-require-cistpl_vers_1-to-contain-4-strings.patch removed from -mm tree akpm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200910092205.n99M5Ivx021129@imap1.linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=bzhao@marvell.com \
    --cc=david.vrabel@csr.com \
    --cc=jic23@cam.ac.uk \
    --cc=linux-mmc@vger.kernel.org \
    --cc=mm-commits@vger.kernel.org \
    --cc=roel.kluin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.