From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yolkfull Chow Subject: Re: [Autotest] [PATCH] Fix a bug in function create in kvm_vm Date: Sat, 10 Oct 2009 16:48:25 +0800 Message-ID: <20091010084825.GE2487@aFu.nay.redhat.com> References: <1254123901-5628-1-git-send-email-yzhou@redhat.com> <6ac58f4f0910051203s6b2c8e12s11ef5714c5328aeb@mail.gmail.com> <20091010082445.GD2487@aFu.nay.redhat.com> Reply-To: Yolkfull Chow Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: kvm@vger.kernel.org, autotest@test.kernel.org To: Lucas Meneghel Rodrigues Return-path: Received: from mx1.redhat.com ([209.132.183.28]:52646 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755680AbZJJIsv (ORCPT ); Sat, 10 Oct 2009 04:48:51 -0400 Content-Disposition: inline In-Reply-To: <20091010082445.GD2487@aFu.nay.redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Sat, Oct 10, 2009 at 04:24:45PM +0800, Yolkfull Chow wrote: > On Mon, Oct 05, 2009 at 04:03:22PM -0300, Lucas Meneghel Rodrigues wr= ote: > > Hi Yolkfull! I've checked your patch, but it turns out that the com= ma > > is valid syntax for the logging module. By any chance you actually = had > > an error with it? >=20 > Hi Lucas, > I just checked, yes it's valid syntax for this module. Before this I = met > a traceback during running autotest and it indicated this line > around,thus I doubt about this by mistake. Sorry for confusing. ;-) >=20 > But I found for the variables in logging.debug(),sometimes it use com= ma > to format while sometimes '%' which will drop code readability. Another reason is if someone who still using kvm_log want to backport codes from this tree, not only need he replace all 'logging' with 'kvm_log' but also need change these comma syntax. ;-) >=20 > Anyway, thanks for checking. >=20 > >=20 > > On Mon, Sep 28, 2009 at 4:45 AM, Yolkfull Chow w= rote: > > > > > > Signed-off-by: Yolkfull Chow > > > --- > > > =A0client/tests/kvm/kvm_vm.py | =A0 =A02 +- > > > =A01 files changed, 1 insertions(+), 1 deletions(-) > > > > > > diff --git a/client/tests/kvm/kvm_vm.py b/client/tests/kvm/kvm_vm= =2Epy > > > index 55220f9..8aeffff 100755 > > > --- a/client/tests/kvm/kvm_vm.py > > > +++ b/client/tests/kvm/kvm_vm.py > > > @@ -406,7 +406,7 @@ class VM: > > > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 self.= process.get_output())) > > > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 return False > > > > > > - =A0 =A0 =A0 =A0 =A0 =A0logging.debug("VM appears to be alive wi= th PID %d", > > > + =A0 =A0 =A0 =A0 =A0 =A0logging.debug("VM appears to be alive wi= th PID %d" % > > > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 self.process.= get_pid()) > > > =A0 =A0 =A0 =A0 =A0 =A0 return True > > > > > > -- > > > 1.6.2.5 > > > > > > _______________________________________________ > > > Autotest mailing list > > > Autotest@test.kernel.org > > > http://test.kernel.org/cgi-bin/mailman/listinfo/autotest > > > > >=20 > >=20 > >=20 > > --=20 > > Lucas > > -- > > To unsubscribe from this list: send the line "unsubscribe kvm" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html