From: David Miller <davem@davemloft.net>
To: johannes@sipsolutions.net
Cc: linville@tuxdriver.com, kalle.valo@iki.fi,
hidave.darkstar@gmail.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] b43: fix ieee80211_rx() context
Date: Sun, 11 Oct 2009 03:39:07 -0700 (PDT) [thread overview]
Message-ID: <20091011.033907.35699436.davem@davemloft.net> (raw)
In-Reply-To: <1255256361.4095.56.camel@johannes.local>
From: Johannes Berg <johannes@sipsolutions.net>
Date: Sun, 11 Oct 2009 12:19:21 +0200
> Due to the way it interacts with the networking
> stack and other parts of mac80211, ieee80211_rx()
> must be called with disabled softirqs.
>
> Michael, the former maintainer of this driver,
> has refused to fix the problem this way instead
> proposing a much more invasive patch that could
> not even be proved correct wrt. locking inside
> mac80211. Regardless of that, he believes this
> to be a bug in mac80211, and has also publicly
> stated [1] that he does not care about this even
> though it is a regression introduced by his own
> patches.
>
> Since nobody else seems to be wanting to fix the
> problem, I'll just fix it for the benefit of the
> many users of this driver.
>
> [1] http://thread.gmane.org/gmane.linux.kernel.wireless.general/39440/focus=40266
>
> Reported-by: Dave Young <hidave.darkstar@gmail.com>
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Acked-by: David S. Miller <davem@davemloft.net>
next prev parent reply other threads:[~2009-10-11 10:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-11 10:19 [PATCH] b43: fix ieee80211_rx() context Johannes Berg
2009-10-11 10:26 ` Michael Buesch
2009-10-11 10:31 ` Johannes Berg
2009-10-11 10:35 ` Michael Buesch
2009-10-12 7:27 ` Holger Schurig
2009-10-11 10:39 ` David Miller [this message]
2009-10-11 11:53 ` Dave Young
2009-10-11 15:59 ` Kalle Valo
2009-10-11 16:02 ` Johannes Berg
2009-10-11 16:08 ` Kalle Valo
2009-10-12 3:08 ` David Miller
2009-10-12 7:49 ` Kalle Valo
2009-10-12 12:29 ` Luciano Coelho
2009-10-12 13:38 ` John W. Linville
2009-10-12 20:08 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091011.033907.35699436.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hidave.darkstar@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=kalle.valo@iki.fi \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.