From: Pavel Machek <pavel@ucw.cz>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Joe Perches <joe@perches.com>, Len Brown <len.brown@intel.com>,
linux-pm@lists.linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 15/21] kernel/power/: use pr_<level> and add pr_fmt(fmt)
Date: Sun, 11 Oct 2009 10:59:00 +0200 [thread overview]
Message-ID: <20091011085859.GA1337@ucw.cz> (raw)
In-Reply-To: <200910102328.37108.rjw@sisk.pl>
> > Here's the same patch redone against -next.
> >
> > Added #define pr_fmt(fmt) "PM: " fmt
> > Converted printk(KERN_<level> to pr_<level>(
> > Converted printks without KERN_ to pr_info or pr_cont
> > Removed hard coded "PM: " prefix from message strings
> > Added pr_fmt() to __initdata strings
> > Integrated multiple line strings
> > All logging messages are now output prefixed with "PM: "
>
> Does this patch depend on any other patch that haven't been merged yet?
>
> I still don't like pr_info(), pr_error() and pr_crit().
Well, rest of kernel uses them, they are shorter, and will save few
bytes too... so why not?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
WARNING: multiple messages have this Message-ID (diff)
From: Pavel Machek <pavel@ucw.cz>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Joe Perches <joe@perches.com>,
linux-kernel@vger.kernel.org, Len Brown <len.brown@intel.com>,
linux-pm@lists.linux-foundation.org
Subject: Re: [PATCH 15/21] kernel/power/: use pr_<level> and add pr_fmt(fmt)
Date: Sun, 11 Oct 2009 10:59:00 +0200 [thread overview]
Message-ID: <20091011085859.GA1337@ucw.cz> (raw)
In-Reply-To: <200910102328.37108.rjw@sisk.pl>
> > Here's the same patch redone against -next.
> >
> > Added #define pr_fmt(fmt) "PM: " fmt
> > Converted printk(KERN_<level> to pr_<level>(
> > Converted printks without KERN_ to pr_info or pr_cont
> > Removed hard coded "PM: " prefix from message strings
> > Added pr_fmt() to __initdata strings
> > Integrated multiple line strings
> > All logging messages are now output prefixed with "PM: "
>
> Does this patch depend on any other patch that haven't been merged yet?
>
> I still don't like pr_info(), pr_error() and pr_crit().
Well, rest of kernel uses them, they are shorter, and will save few
bytes too... so why not?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2009-10-11 8:59 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-05 0:53 [PATCH 00/21] pr_dbg, pr_fmt Joe Perches
2009-10-05 1:18 ` Joe Perches
2009-10-05 1:18 ` Joe Perches
2009-10-05 0:53 ` Joe Perches
2009-10-05 0:53 ` [PATCH 01/21] include/linux/ dynamic_debug.h kernel.h: Remove KBUILD_MODNAME from dynamic_pr_debug, add pr_dbg Joe Perches
2009-10-05 0:53 ` [PATCH 02/21] ftrace.c: Add #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt Joe Perches
2009-10-05 13:10 ` Steven Rostedt
2009-10-05 17:21 ` Joe Perches
2009-10-05 17:32 ` Steven Rostedt
2009-10-12 6:10 ` [tip:tracing/core] " tip-bot for Joe Perches
2009-10-05 0:53 ` [PATCH 03/21] mtrr: use pr_<level> and pr_fmt Joe Perches
2009-10-05 0:53 ` [PATCH 04/21] microcode: use pr_<level> and add pr_fmt Joe Perches
2009-10-05 0:53 ` [PATCH 05/21] amd_iommu.c: use pr_<level> and add pr_fmt(fmt) Joe Perches
2009-10-12 15:00 ` Joerg Roedel
2009-10-12 17:00 ` Joe Perches
2009-10-05 0:53 ` [PATCH 06/21] es7000_32.c: " Joe Perches
2009-10-05 0:53 ` [PATCH 07/21] arch/x86/kernel/apic/: " Joe Perches
2009-10-05 0:53 ` [PATCH 08/21] mcheck/: " Joe Perches
2009-10-05 0:53 ` [PATCH 09/21] arch/x86/kernel/setup_percpu.c: " Joe Perches
2009-10-05 0:53 ` [PATCH 10/21] arch/x86/kernel/cpu/: " Joe Perches
2009-10-05 0:53 ` [PATCH 11/21] i8254.c: Add pr_fmt(fmt) Joe Perches
2009-10-05 0:53 ` [PATCH 12/21] kmmio.c: Add and use pr_fmt(fmt) Joe Perches
2009-10-05 0:53 ` [PATCH 13/21] testmmiotrace.c: " Joe Perches
2009-10-12 6:10 ` [tip:tracing/core] " tip-bot for Joe Perches
2009-10-05 0:53 ` [PATCH 14/21] crypto/: use pr_<level> and add pr_fmt(fmt) Joe Perches
2009-10-05 0:53 ` [PATCH 15/21] kernel/power/: " Joe Perches
2009-10-05 0:53 ` Joe Perches
2009-10-05 19:43 ` Rafael J. Wysocki
2009-10-05 19:43 ` Rafael J. Wysocki
2009-10-05 20:31 ` Joe Perches
2009-10-05 20:31 ` Joe Perches
2009-10-05 22:37 ` Rafael J. Wysocki
2009-10-05 22:37 ` Rafael J. Wysocki
2009-10-09 3:53 ` Joe Perches
2009-10-09 3:53 ` Joe Perches
2009-10-10 21:28 ` Rafael J. Wysocki
2009-10-10 21:28 ` Rafael J. Wysocki
2009-10-11 1:49 ` Joe Perches
2009-10-11 1:49 ` Joe Perches
2009-10-11 8:59 ` Pavel Machek [this message]
2009-10-11 8:59 ` Pavel Machek
2009-10-05 0:53 ` [PATCH 16/21] kernel/kexec.c: " Joe Perches
2009-10-05 0:53 ` Joe Perches
2009-10-05 12:01 ` Eric W. Biederman
2009-10-05 12:01 ` Eric W. Biederman
2009-10-05 17:57 ` Joe Perches
2009-10-05 17:57 ` Joe Perches
2009-10-05 0:53 ` [PATCH 17/21] crypto/async_tx/raid6test.c: " Joe Perches
2009-10-05 0:53 ` [PATCH 18/21] arch/x86/mm/mmio-mod.c: use pr_fmt Joe Perches
2009-10-05 0:53 ` [PATCH 19/21] drivers/net/bonding/: : " Joe Perches
2009-10-05 7:12 ` David Miller
2009-10-05 0:53 ` [PATCH 20/21] drivers/net/tlan: use pr_<level> and add pr_fmt(fmt) Joe Perches
2009-10-05 7:12 ` David Miller
2009-10-05 0:53 ` [PATCH 21/21] drivers/net/tlan.h: Convert printk(KERN_DEBUG to pr_dbg( Joe Perches
2009-10-05 7:12 ` David Miller
2009-10-05 7:16 ` Joe Perches
2009-10-05 7:20 ` David Miller
2009-10-05 21:15 ` Rafael J. Wysocki
2009-10-05 21:28 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091011085859.GA1337@ucw.cz \
--to=pavel@ucw.cz \
--cc=joe@perches.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.