All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Zidlicky <rz@linux-m68k.org>
To: Bob Copeland <me@bobcopeland.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: 2.6.31.[12] ath5k regression
Date: Sun, 11 Oct 2009 14:26:16 +0200	[thread overview]
Message-ID: <20091011122616.GA27105@linux-m68k.org> (raw)
In-Reply-To: <20091010125824.GA18841@hash.localnet>

On Sat, Oct 10, 2009 at 08:58:24AM -0400, Bob Copeland wrote:
> On Fri, Oct 09, 2009 at 04:39:22PM +0200, Richard Zidlicky wrote:
> > -       ret = ath5k_hw_reset(ah, sc->opmode, sc->curchan, true);
> > +       ret = ath5k_hw_reset(ah, sc->opmode, sc->curchan, chan != NULL);
> >         if (ret) {
> >                 ATH5K_ERR(sc, "can't reset hardware (%d)\n", ret);
> >                 goto err;
> 
> So, this change effectively just ensures we now program the pcu registers
> at startup (every other time chan should not be null).  So my guess is
> programming the pcu actually causes some problem.  Can you try this patch
> instead?

thanks, compiling it right now. Not quite sure - which version of this
> > -       ret = ath5k_hw_reset(ah, sc->opmode, sc->curchan, true);
> > +       ret = ath5k_hw_reset(ah, sc->opmode, sc->curchan, chan != NULL);

is it supposed to be tested with?

Richard

  parent reply	other threads:[~2009-10-11 12:32 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-21 13:49 kernel crashes, 2.6.30, rt2x00, ath5k, ieee80211_get_*_rate, automatic rate control Richard Zidlicky
2009-06-21 18:04 ` Bob Copeland
2009-06-21 20:38   ` Richard Zidlicky
2009-06-22 20:15   ` Richard Zidlicky
2009-06-23 17:46   ` Richard Zidlicky
2009-06-23 20:25     ` Bob Copeland
2009-06-25  8:36       ` Richard Zidlicky
2009-07-05 12:31         ` Bob Copeland
2009-09-28 22:23           ` ath5k, wifi enable hotkeys Richard Zidlicky
2009-10-09 14:39           ` 2.6.31.[12] ath5k regression Richard Zidlicky
2009-10-10 12:58             ` Bob Copeland
2009-10-10 13:31               ` Bob Copeland
2009-10-11 12:26               ` Richard Zidlicky [this message]
2009-10-11 13:30                 ` Bob Copeland
2009-10-11 22:00                   ` Richard Zidlicky
2009-10-11 22:23                     ` Bob Copeland
2009-10-12 20:23                       ` Richard Zidlicky
2009-10-12 23:54                         ` Bob Copeland
2009-10-13 19:37                           ` Richard Zidlicky
2009-12-06  9:49                           ` Richard Zidlicky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091011122616.GA27105@linux-m68k.org \
    --to=rz@linux-m68k.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=me@bobcopeland.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.