All of lore.kernel.org
 help / color / mirror / Atom feed
From: Frederic Weisbecker <fweisbec@gmail.com>
To: Christoph Hellwig <hch@lst.de>
Cc: mingo@elte.hu, linux-kernel@vger.kernel.org
Subject: Re: perf trace errors
Date: Sun, 11 Oct 2009 22:23:54 +0200	[thread overview]
Message-ID: <20091011202353.GA5486@nowhere> (raw)
In-Reply-To: <20091011124030.GA3859@lst.de>

On Sun, Oct 11, 2009 at 02:40:30PM +0200, Christoph Hellwig wrote:
> On Sun, Oct 11, 2009 at 02:19:28PM +0200, Frederic Weisbecker wrote:
> > Yeah, there are still some trace events that are not well supported
> > in perf trace, for now... I'll fix that by the time.
> 
> Any idea what is the missing part?  I tried to understand the code but
> I haven't even managed to grasp the data structures yet.
> 
> The weird thing is that these message seem to come from parsing of
> the filters, and a simple trace the whole system trace shouldn't
> really have to set any filters anyway, nor should the filters depdend
> on what trace point you use.
> 
> Note that the in addition to all the block trace points also all my
> new xfs tracepoints also give errors from perf trace.  Things tend
> to work quite nicely with the ASCII output from the kernel.
> 


It's about the trace event format file parsing, especially the format
line:

print fmt: "%d,%d %s %llu + %u [%s]", ((unsigned int) ((REC->dev) >> 20)), ((unsigned int) ((REC->dev) & ((1U << 20) 
- 1))), REC->rwbs, (unsigned long long)REC->sector, REC->nr_sector, REC->comm

This is done from tools/perf/util/trace-event-parse.c

It is supposed to handle such cases already, not sure exactly where is
the problem currently, that needs some investigation.


  reply	other threads:[~2009-10-11 20:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-11  2:54 perf trace errors Christoph Hellwig
2009-10-11 12:19 ` Frederic Weisbecker
2009-10-11 12:40   ` Christoph Hellwig
2009-10-11 20:23     ` Frederic Weisbecker [this message]
2009-10-16  8:32 ` Ingo Molnar
2009-10-25  7:17   ` Christoph Hellwig
2009-10-25 23:43     ` Frederic Weisbecker
2009-10-29 21:24       ` Steven Rostedt
2009-11-02  1:24         ` Frederic Weisbecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091011202353.GA5486@nowhere \
    --to=fweisbec@gmail.com \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.