From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mx7eP-0005jn-5t for qemu-devel@nongnu.org; Sun, 11 Oct 2009 19:16:29 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mx7eJ-0005iz-JL for qemu-devel@nongnu.org; Sun, 11 Oct 2009 19:16:28 -0400 Received: from [199.232.76.173] (port=33003 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mx7eJ-0005iw-F9 for qemu-devel@nongnu.org; Sun, 11 Oct 2009 19:16:23 -0400 Received: from mtaout03-winn.ispmail.ntl.com ([81.103.221.49]:35693) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Mx7eJ-0005Wt-2M for qemu-devel@nongnu.org; Sun, 11 Oct 2009 19:16:23 -0400 Date: Mon, 12 Oct 2009 00:17:36 +0100 From: Stuart Brady Subject: Re: [Qemu-devel] [PATCH] tcg, tci: Add TCG and interpreter for bytecode (virtual machine) Message-ID: <20091011231735.GA10123@miranda.arrow> References: <4AC0E93A.6010605@mail.berlios.de> <1254156621-28559-1-git-send-email-weil@mail.berlios.de> <20091004182724.GA26105@miranda.arrow> <4AD208F5.9000203@mail.berlios.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4AD208F5.9000203@mail.berlios.de> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: qemu-devel@nongnu.org On Sun, Oct 11, 2009 at 06:33:57PM +0200, Stefan Weil wrote: > Stuart Brady schrieb: > > exec-all.h defines 'USE_DIRECT_JUMP' based on the host architecture, > > which is not relevant under TCI. Also, a tb_set_jmp_target1() > > implementation is needed for TCI. > Done. Tested with mips / mipsel host. I think the #ifdef CONFIG_TCG_INTERPRETER sections belong before the arch-specific sections. :-) > Alignment is still to be done (my test platforms don't need it). I will do this at some point if nobody beats me to it. :-) BTW, I'm wondering about certain places that require host-specific code... for example: * qemu-lock.h, which is used by cpu_exec() for the tb lock and by cpu_unlink_tb() for non-NPTL hosts. * The generic cpu_get_real_ticks() doesn't seem great... I suppose the MIPS version using clock() might be more appropriate? Apart from this, I suppose user mode emulation simply has to depend on host-specific code for signal handling... :-( I gather INDEX_op_call handling could be improved? Presumably that's really just a matter of casting to the right type of function pointer when making each call? Cheers, -- Stuart Brady