From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yolkfull Chow Subject: Re: [Autotest] [PATCH] Fix a bug in function create in kvm_vm Date: Mon, 12 Oct 2009 14:58:05 +0800 Message-ID: <20091012065805.GC2501@aFu.nay.redhat.com> References: <1254123901-5628-1-git-send-email-yzhou@redhat.com> <6ac58f4f0910051203s6b2c8e12s11ef5714c5328aeb@mail.gmail.com> <20091010082445.GD2487@aFu.nay.redhat.com> <20091010084825.GE2487@aFu.nay.redhat.com> <1255305185.3849.2021.camel@localhost.localdomain> Reply-To: Yolkfull Chow Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, autotest@test.kernel.org To: Lucas Meneghel Rodrigues Return-path: Received: from mx1.redhat.com ([209.132.183.28]:55507 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752782AbZJLG6f (ORCPT ); Mon, 12 Oct 2009 02:58:35 -0400 Content-Disposition: inline In-Reply-To: <1255305185.3849.2021.camel@localhost.localdomain> Sender: kvm-owner@vger.kernel.org List-ID: On Sun, Oct 11, 2009 at 08:53:05PM -0300, Lucas Meneghel Rodrigues wrote: > On Sat, 2009-10-10 at 16:48 +0800, Yolkfull Chow wrote: > > On Sat, Oct 10, 2009 at 04:24:45PM +0800, Yolkfull Chow wrote: > > > On Mon, Oct 05, 2009 at 04:03:22PM -0300, Lucas Meneghel Rodrigues wrote: > > > > Hi Yolkfull! I've checked your patch, but it turns out that the comma > > > > is valid syntax for the logging module. By any chance you actually had > > > > an error with it? > > > > > > Hi Lucas, > > > I just checked, yes it's valid syntax for this module. Before this I met > > > a traceback during running autotest and it indicated this line > > > around,thus I doubt about this by mistake. Sorry for confusing. ;-) > > > > > > But I found for the variables in logging.debug(),sometimes it use comma > > > to format while sometimes '%' which will drop code readability. > > > > Another reason is if someone who still using kvm_log want to backport > > codes from this tree, not only need he replace all 'logging' with > > 'kvm_log' but also need change these comma syntax. ;-) > > Yes, we prefer using comma on logging statements allways, but sometimes > we make mistakes and use the standard string format with %. > > When porting code, try to keep in mind that and try to use allways the > comma, but don't worry too much about it... just general guidelines :) Ok, that could be the style. Thanks very much for remind. :) Cheers, > > Lucas > > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html