All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Lendacky <tahm@linux.vnet.ibm.com>
To: kvm@vger.kernel.org
Subject: QemuOpts changes breaks multiple nic options
Date: Mon, 12 Oct 2009 17:05:03 -0500	[thread overview]
Message-ID: <200910121705.03870.tahm@linux.vnet.ibm.com> (raw)

The recent change to QemuOpts for the -net nic option breaks specifying -net 
nic,... more than once.  The net_init_nic function's return value in net.c is 
a table index, which is non-zero after the first time it is called.  The 
qemu_opts_foreach function in qemu-option.c receives the non-zero return value 
and stops processing further -net options (like associated -net tap options).  
It looks like the usb net function makes use of the index value, so the fix 
might best be to have qemu_opts_foreach check for a return code < 0 as being 
an error?

Tom Lendacky

             reply	other threads:[~2009-10-12 22:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-12 22:05 Tom Lendacky [this message]
2009-10-13  8:58 ` QemuOpts changes breaks multiple nic options Mark McLoughlin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200910121705.03870.tahm@linux.vnet.ibm.com \
    --to=tahm@linux.vnet.ibm.com \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.