From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MxOqv-0003S3-L3
	for qemu-devel@nongnu.org; Mon, 12 Oct 2009 13:38:33 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MxOqq-0003E2-GE
	for qemu-devel@nongnu.org; Mon, 12 Oct 2009 13:38:32 -0400
Received: from [199.232.76.173] (port=45896 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MxOqq-0003DZ-3P
	for qemu-devel@nongnu.org; Mon, 12 Oct 2009 13:38:28 -0400
Received: from mtaout01-winn.ispmail.ntl.com ([81.103.221.47]:8464)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <sdbrady@ntlworld.com>) id 1MxOqo-0003kK-R2
	for qemu-devel@nongnu.org; Mon, 12 Oct 2009 13:38:27 -0400
Date: Mon, 12 Oct 2009 18:39:42 +0100
From: Stuart Brady <sdbrady@ntlworld.com>
Subject: Re: [Qemu-devel] [PATCH] tcg,
	tci: Add TCG and interpreter for bytecode (virtual machine)
Message-ID: <20091012173942.GA11801@miranda.arrow>
References: <4AC0E93A.6010605@mail.berlios.de>
	<1254156621-28559-1-git-send-email-weil@mail.berlios.de>
	<20091004182724.GA26105@miranda.arrow>
	<4AD208F5.9000203@mail.berlios.de>
	<20091011231735.GA10123@miranda.arrow>
	<Pine.LNX.4.64.0910120349190.5337@linmac.oyster.ru>
	<20091012064652.GA10789@miranda.arrow>
	<Pine.LNX.4.64.0910121624010.2142@linmac.oyster.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Pine.LNX.4.64.0910121624010.2142@linmac.oyster.ru>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: malc <av1474@comtv.ru>
Cc: qemu-devel@nongnu.org

On Mon, Oct 12, 2009 at 04:33:10PM +0400, malc wrote:
> On Mon, 12 Oct 2009, Stuart Brady wrote:
> 
> > Huh?  If you're using a function pointer with the *correct* type,
> > I hardly see how that's not sufficient.
> 
> Let me give you an example:
> 
[snip]

*Mind boggles* :-)

You seem to be ignoring the words "correct type" in all of my sentences.
My suggestion was to give op_call handling the information it that needs
iff TCI is used.  Yes, the code in tcg_gen_callN() is clearly not
appropriate for TCI, although I'd somehow missed the fact that it may
also need to be changed in future to support other new TCG back-ends.

I'm quite aware that functions must be invoked using the *correct type*
of function pointer, though.  Perhaps I wasn't specific enough in what
I said, but please, I'm not completely clueless... :-)

Cheers,
-- 
Stuart Brady