From: "John W. Linville" <linville@tuxdriver.com>
To: Reinette Chatre <reinette.chatre@intel.com>
Cc: linux-wireless@vger.kernel.org,
ipw3945-devel@lists.sourceforge.net,
Ben Cahill <ben.m.cahill@intel.com>
Subject: Re: [PATCH 02/17 v2.6.32] iwl3945: update iwl3945_apm_init()
Date: Mon, 12 Oct 2009 14:59:43 -0400 [thread overview]
Message-ID: <20091012185943.GC2794@tuxdriver.com> (raw)
In-Reply-To: <1255119634-3060-3-git-send-email-reinette.chatre@intel.com>
On Fri, Oct 09, 2009 at 01:20:18PM -0700, Reinette Chatre wrote:
> From: Ben Cahill <ben.m.cahill@intel.com>
>
> Update iwl3945_apm_init() to set up device registers in sequence most recently
> recommended by factory.
>
> Add resets for APMG interrupts and radio chip, formerly done only in
> iwl3945_apm_reset(); moving them here assures that apm_init() will do
> a complete job of preparing hardware not only after platform boot,
> but also after apm_stop() has executed (due to rfkill, ifconfig down,
> driver unload, etc.). This is in preparation to completely remove apm_reset().
>
> Add some comments.
>
> Signed-off-by: Ben Cahill <ben.m.cahill@intel.com>
> Signed-off-by: Reinette Chatre <reinette.chatre@intel.com>
Is this actually a regression? Can you provide a reference to the bug report?
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2009-10-12 19:01 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-09 20:20 [PATCH 0/17] iwlwifi driver updates 10/9/2009 Reinette Chatre
2009-10-09 20:20 ` [PATCH 01/17 v2.6.32 and w-t] iwlwifi: change the order of freeing memory Reinette Chatre
2009-10-09 20:20 ` [PATCH 02/17 v2.6.32] iwl3945: update iwl3945_apm_init() Reinette Chatre
2009-10-12 18:59 ` John W. Linville [this message]
2009-10-12 19:57 ` reinette chatre
2009-10-13 9:11 ` [ipw3945-devel] " Vedran Rodic
2009-10-13 16:59 ` reinette chatre
2009-10-09 20:20 ` [PATCH 02/17 w-t] " Reinette Chatre
2009-10-09 20:20 ` [PATCH 03/17 v2.6.32 and w-t] iwlwifi: turn off device when not used Reinette Chatre
2009-10-12 19:00 ` John W. Linville
2009-10-09 20:20 ` [PATCH 04/17] iwl3945: remove unnecessary call to apm_ops.reset() Reinette Chatre
2009-10-09 20:20 ` [PATCH 05/17] iwlagn, iwl3945: remove apm_reset() functions Reinette Chatre
2009-10-09 20:20 ` [PATCH 06/17] iwlwifi: remove duplicated/unused definition Reinette Chatre
2009-10-09 20:20 ` [PATCH 07/17] iwlwifi: additional items in sensitivity range table Reinette Chatre
2009-10-09 20:20 ` [PATCH 08/17] iwlwifi: fix userspace setting of sleep_level_override Reinette Chatre
2009-10-09 20:20 ` [PATCH 09/17] iwl3945: streamline iwl3945_rfkill_poll() Reinette Chatre
2009-10-09 20:20 ` [PATCH 10/17] iwl3945: move iwl_power_initialize() Reinette Chatre
2009-10-09 20:20 ` [PATCH 11/17] iwlwifi: dynamic allocate tx queue structure Reinette Chatre
2009-10-09 20:20 ` [PATCH 12/17] iwlwifi: showing accumulative ucode statistics counters Reinette Chatre
2009-10-09 20:20 ` [PATCH 13/17] iwlwifi/iwl3945: unify rts_tx_cmd_flag Reinette Chatre
2009-10-09 20:20 ` [PATCH 14/17] iwl3945: rename tx to tx_cmd Reinette Chatre
2009-10-09 20:20 ` [PATCH 15/17] iwlwifi/iwl3945: remove data_retry_limit Reinette Chatre
2009-10-09 20:20 ` [PATCH 16/17] iwl3945: rearrange the code Reinette Chatre
2009-10-09 20:20 ` [PATCH 17/17] iwlwifi: update channel switch command API Reinette Chatre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091012185943.GC2794@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=ben.m.cahill@intel.com \
--cc=ipw3945-devel@lists.sourceforge.net \
--cc=linux-wireless@vger.kernel.org \
--cc=reinette.chatre@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.