From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH] make blkfront/blktagp2 respect the elevator=xyz command line option Date: Mon, 12 Oct 2009 15:32:40 -0400 Message-ID: <20091012193240.GB15826@phenom.dumpdata.com> References: <1255105914-2570-1-git-send-email-pbonzini@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1255105914-2570-1-git-send-email-pbonzini@redhat.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Paolo Bonzini Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On Fri, Oct 09, 2009 at 06:31:54PM +0200, Paolo Bonzini wrote: > For some workloads, CFQ has better performance than the no-op scheduler > that is forced by the blkfront driver. The only way to set a different > scheduler is the sysfs interface, because elevator_init is called > unconditionally. This patch allows one to use "elevator=cfq" as well. > > While one could argue that the driver's behavior is expected (after all > "elevator=cfq" is the default and should not have any effect), the > do-what-I-mean behavior implemented by this patch is more logical. > > Signed-off-by: Paolo Bonzini Are you going to follow another patch for the upstream driver as well? Or is that not needed at all in the 2.6.31 tree?