From: Sasha Khapyorsky <sashak-smomgflXvOZWk0Htik3J/w@public.gmane.org>
To: linux-rdma <linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Cc: "Stan C. Smith" <stan.smith-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: [PATCH] osmtest: initialize attr_array[] on declaration
Date: Mon, 12 Oct 2009 23:36:31 +0200 [thread overview]
Message-ID: <20091012213631.GF13830@me> (raw)
In-Reply-To: <F7FAC243E7364BC582B7FCDBE42FB384-Zpru7NauK7drdx17CPfAsdBPR1lH4CV8@public.gmane.org>
Initialize attr_array[] arrays on declaration.
Signed-off-by: Sasha Khapyorsky <sashak-smomgflXvOZWk0Htik3J/w@public.gmane.org>
---
opensm/osmtest/main.c | 14 ++------------
opensm/osmtest/osmtest.c | 8 +-------
2 files changed, 3 insertions(+), 19 deletions(-)
diff --git a/opensm/osmtest/main.c b/opensm/osmtest/main.c
index 11bb0c8..4cead91 100644
--- a/opensm/osmtest/main.c
+++ b/opensm/osmtest/main.c
@@ -213,14 +213,9 @@ static void print_all_guids(IN osmtest_t * p_osmt)
{
ib_api_status_t status;
uint32_t num_ports = MAX_LOCAL_IBPORTS;
- ib_port_attr_t attr_array[MAX_LOCAL_IBPORTS];
+ ib_port_attr_t attr_array[MAX_LOCAL_IBPORTS] = { {0} };
uint32_t i;
- for (i = 0; i < num_ports; i++) {
- attr_array[i].num_pkeys = 0;
- attr_array[i].p_pkey_table = NULL;
- }
-
/*
Call the transport layer for a list of local port
GUID values.
@@ -246,14 +241,9 @@ ib_net64_t get_port_guid(IN osmtest_t * p_osmt, uint64_t port_guid)
{
ib_api_status_t status;
uint32_t num_ports = MAX_LOCAL_IBPORTS;
- ib_port_attr_t attr_array[MAX_LOCAL_IBPORTS];
+ ib_port_attr_t attr_array[MAX_LOCAL_IBPORTS] = { {0} };
uint32_t i;
- for (i = 0; i < num_ports; i++) {
- attr_array[i].num_pkeys = 0;
- attr_array[i].p_pkey_table = NULL;
- }
-
/*
Call the transport layer for a list of local port
GUID values.
diff --git a/opensm/osmtest/osmtest.c b/opensm/osmtest/osmtest.c
index a1457b8..9dd1117 100644
--- a/opensm/osmtest/osmtest.c
+++ b/opensm/osmtest/osmtest.c
@@ -7236,16 +7236,10 @@ osmtest_bind(IN osmtest_t * p_osmt,
uint32_t port_index;
ib_api_status_t status;
uint32_t num_ports = MAX_LOCAL_IBPORTS;
- ib_port_attr_t attr_array[MAX_LOCAL_IBPORTS];
- uint32_t i;
+ ib_port_attr_t attr_array[MAX_LOCAL_IBPORTS] = { {0} };
OSM_LOG_ENTER(&p_osmt->log);
- for (i = 0; i < num_ports; i++) {
- attr_array[i].num_pkeys = 0;
- attr_array[i].p_pkey_table = NULL;
- }
-
/*
* Call the transport layer for a list of local port
* GUID values.
--
1.6.5
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2009-10-12 21:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-12 17:21 [PATCH] osmtest - fix signed unsigned comparisons Stan C. Smith
2009-10-12 21:35 ` Sasha Khapyorsky
[not found] ` <F7FAC243E7364BC582B7FCDBE42FB384-Zpru7NauK7drdx17CPfAsdBPR1lH4CV8@public.gmane.org>
2009-10-12 21:36 ` Sasha Khapyorsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091012213631.GF13830@me \
--to=sashak-smomgflxvozwk0htik3j/w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=stan.smith-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.