From: Sasha Khapyorsky <sashak@voltaire.com>
To: "Smith, Stan" <stan.smith@intel.com>
Cc: "ofw@lists.openfabrics.org" <ofw@lists.openfabrics.org>,
'linux-rdma' <linux-rdma@vger.kernel.org>
Subject: Re: [PATCH] opensm - standardize on a single Windows #define
Date: Tue, 13 Oct 2009 00:00:41 +0200 [thread overview]
Message-ID: <20091012220041.GL13830@me> (raw)
In-Reply-To: <3F6F638B8D880340AB536D29CD4C1E1912C8846161@orsmsx501.amr.corp.intel.com>
On 10:16 Thu 08 Oct , Smith, Stan wrote:
> Hefty, Sean wrote:
> >> Code cleanup, standardize on a single Windows #define '__WIN__';
> >> WIN32 --> __WIN__. Flip usage of ifndef WIN32 --> ifdef __GNUC__
> >
> > GNUC indicates a specific compiler, not a platform, which is what the
> > check is for.
>
> To the best of my understanding OpenSM is built for Linux/OFED, Solaris and Windows.
Also some embedded platforms and we don't know what in a future.
'#ifdef __WIN__' and '#ifndef __GNUC__' are not equivalent.
Sasha
next prev parent reply other threads:[~2009-10-12 22:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-08 16:08 [PATCH] opensm - standardize on a single Windows #define Stan C. Smith
2009-10-08 17:06 ` Sean Hefty
2009-10-08 17:16 ` Smith, Stan
2009-10-08 17:22 ` Sean Hefty
2009-10-08 18:12 ` Smith, Stan
2009-10-12 22:00 ` Sasha Khapyorsky [this message]
2009-10-12 22:24 ` Smith, Stan
2009-10-12 22:29 ` Smith, Stan
[not found] ` <3F6F638B8D880340AB536D29CD4C1E1912C896BBFC-osO9UTpF0USkrb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2009-10-13 4:15 ` [ofw] " Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091012220041.GL13830@me \
--to=sashak@voltaire.com \
--cc=linux-rdma@vger.kernel.org \
--cc=ofw@lists.openfabrics.org \
--cc=stan.smith@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.