All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: Nir Tzachar <nir.tzachar@gmail.com>
Cc: "David Miller" <davem@davemloft.net>,
	netdev@vger.kernel.org,
	"Caitlin Bestler" <caitlin.bestler@gmail.com>,
	"Chris Van Hoof" <vanhoof@redhat.com>,
	"Clark Williams" <williams@redhat.com>,
	"Neil Horman" <nhorman@tuxdriver.com>,
	"Nivedita Singhvi" <niv@us.ibm.com>,
	"Paul Moore" <paul.moore@hp.com>,
	"Rémi Denis-Courmont" <remi.denis-courmont@nokia.com>,
	"Steven Whitehouse" <steve@chygwyn.com>
Subject: Re: [PATCH 1/1] net: Introduce recvmmsg socket syscall
Date: Mon, 12 Oct 2009 22:56:37 -0300	[thread overview]
Message-ID: <20091013015637.GB21809@ghostprotocols.net> (raw)
In-Reply-To: <9b2db90b0910121053h3c422beet487cc9a9b9be2894@mail.gmail.com>

Em Mon, Oct 12, 2009 at 07:53:43PM +0200, Nir Tzachar escreveu:
> Hi Arnaldo.
> 
> Do you have any plans on how we can further investigate the delays I
> have seen with the second part of the patch? I have tried to simply
> unlock/lock the socket's mutex every couple of iterations inside the

Yeah, that is what tcp does, look at tcp_recvmsg (net/ipv4/tcp.c, line
1505), so I think we should do something along those lines, exactly when
and after which tests is a matter of experimentation.

I'll resume investigation tomorrow.

> loop (to allow the system to process some backlog), but this seems to
> have little to no effect.
 
> Also, a way to enable/disable the no_lock version at runtime will
> greatly help in testing. Maybe by first introducing a second syscall,
> recvmmsg_no_lock, for testing purposes??

I'll come up with a way for that to be possible.

- Arnaldo

  reply	other threads:[~2009-10-13  2:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-12 16:20 [PATCH 1/1] net: Introduce recvmmsg socket syscall Arnaldo Carvalho de Melo
2009-10-12 17:53 ` Nir Tzachar
2009-10-13  1:56   ` Arnaldo Carvalho de Melo [this message]
2009-10-13  6:40 ` David Miller
2009-10-13 13:14   ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091013015637.GB21809@ghostprotocols.net \
    --to=acme@ghostprotocols.net \
    --cc=caitlin.bestler@gmail.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@tuxdriver.com \
    --cc=nir.tzachar@gmail.com \
    --cc=niv@us.ibm.com \
    --cc=paul.moore@hp.com \
    --cc=remi.denis-courmont@nokia.com \
    --cc=steve@chygwyn.com \
    --cc=vanhoof@redhat.com \
    --cc=williams@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.