From: Ben Dooks <ben@fluff.org.uk>
To: sam@ravnborg.org, linux-kernel@vger.kernel.org
Cc: spi-devel-general@lists.sourceforge.net
Subject: changing module from single to multi-file build
Date: Tue, 13 Oct 2009 09:24:27 +0100 [thread overview]
Message-ID: <20091013082427.GC7793@fluff.org.uk> (raw)
I have a driver, drivers/spi/spi_s3c24xx.c in this case that I have
written an FIQ handler for which requires some assembly code. My attempts
at trying to change it so that I can build a single module with both the
C and ASM code linked together have not yet been a success.
The original makefile bit from drivers/spi/Makefile was:
obj-$(CONFIG_SPI_S3C24XX) += spi_s3c24xx.o
This allows it to work as a kernel builtin:
obj-$(CONFIG_SPI_S3C24XX) += spi_s3c24xx.o
obj-$(CONFIG_SPI_S3C24XX_FIQ) += spi_s3c24xx_fiq.o
I tried adding the following to the file, but this does not make
the FIQ code, I assume as there is still drivers/spi/spi_s3c24xx.c.
obj-spi_s3c24xx-y := spi_s3c24xx.o
obj-spi_s3c24xx-$(CONFIG_SPI_S3C24XX_FIQ) += spi_s3c24xx_fiq.o
Should I rename drivers/spi/spi_s3c24xx.c to something else to avoid
changing the module name, change the module name to avoid renaming the .c
to say spi_s3c24xx_hw (we have a gpio implementation, but that could easily
be removed in favour of gpiolib). Or is there something else that could
be done?
Note, I was initially against renaming the module, but with module autoload
working so well it seems easier to rename the module than try renaming the
.c file.
--
Ben (ben@fluff.org, http://www.fluff.org/)
'a smiley only costs 4 bytes'
next reply other threads:[~2009-10-13 8:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-13 8:24 Ben Dooks [this message]
[not found] ` <20091013082427.GC7793-elnMNo+KYs3pIgCt6eIbzw@public.gmane.org>
2009-10-13 18:39 ` changing module from single to multi-file build Sam Ravnborg
2009-10-13 18:39 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091013082427.GC7793@fluff.org.uk \
--to=ben@fluff.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.